jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-26 10:17:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not call update() in constructor (#8048)

Browse Source
This commit is contained in:
Fabian Affolter 2017-06-15 21:23:55 +02:00 committed by Pascal Vizeli
parent 8eb29787a5
commit 69c919183a
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/sensor/snmp.py
View File

@ -9,12 +9,11 @@ from datetime import timedelta
import voluptuous as vol import voluptuous as vol
import homeassistant.helpers.config_validation as cv
from homeassistant.components.sensor import PLATFORM_SCHEMA from homeassistant.components.sensor import PLATFORM_SCHEMA
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.const import ( from homeassistant.const import (
CONF_HOST, CONF_NAME, CONF_PORT, CONF_UNIT_OF_MEASUREMENT) CONF_HOST, CONF_NAME, CONF_PORT, CONF_UNIT_OF_MEASUREMENT)
import homeassistant.helpers.config_validation as cv
from homeassistant.util import Throttle
REQUIREMENTS = ['pysnmp==4.3.7'] REQUIREMENTS = ['pysnmp==4.3.7']
@ -35,7 +34,7 @@ SNMP_VERSIONS = {
'2c': 1 '2c': 1
} }
MIN_TIME_BETWEEN_UPDATES = timedelta(seconds=10) SCAN_INTERVAL = timedelta(seconds=10)
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Required(CONF_BASEOID): cv.string, vol.Required(CONF_BASEOID): cv.string,
@ -75,7 +74,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
return False return False
else: else:
data = SnmpData(host, port, community, baseoid, version) data = SnmpData(host, port, community, baseoid, version)
add_devices([SnmpSensor(data, name, unit)]) add_devices([SnmpSensor(data, name, unit)], True)
class SnmpSensor(Entity): class SnmpSensor(Entity):
@ -87,7 +86,6 @@ class SnmpSensor(Entity):
self._name = name self._name = name
self._state = None self._state = None
self._unit_of_measurement = unit_of_measurement self._unit_of_measurement = unit_of_measurement
self.update()
@property @property
def name(self): def name(self):
@ -122,7 +120,6 @@ class SnmpData(object):
self._version = SNMP_VERSIONS[version] self._version = SNMP_VERSIONS[version]
self.value = None self.value = None
@Throttle(MIN_TIME_BETWEEN_UPDATES)
def update(self): def update(self):
"""Get the latest data from the remote SNMP capable host.""" """Get the latest data from the remote SNMP capable host."""
from pysnmp.hlapi import ( from pysnmp.hlapi import (