From 6b2a4c975c258ae4645c0e0d4224a37589c47467 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Thu, 8 May 2025 23:44:06 +0200 Subject: [PATCH] Cleanup unused CONF_IP_ADDRESS from SamsungTV tests (#144379) --- tests/components/samsungtv/const.py | 3 --- tests/components/samsungtv/snapshots/test_diagnostics.ambr | 3 --- tests/components/samsungtv/test_config_flow.py | 6 +----- tests/components/samsungtv/test_media_player.py | 2 -- 4 files changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/components/samsungtv/const.py b/tests/components/samsungtv/const.py index 7a367294581..7078f088217 100644 --- a/tests/components/samsungtv/const.py +++ b/tests/components/samsungtv/const.py @@ -8,7 +8,6 @@ from homeassistant.components.samsungtv.const import ( ) from homeassistant.const import ( CONF_HOST, - CONF_IP_ADDRESS, CONF_MAC, CONF_METHOD, CONF_MODEL, @@ -33,7 +32,6 @@ MOCK_CONFIG_ENCRYPTED_WS = { } MOCK_ENTRYDATA_ENCRYPTED_WS = { **MOCK_CONFIG_ENCRYPTED_WS, - CONF_IP_ADDRESS: "test", CONF_METHOD: "encrypted", CONF_MAC: "aa:bb:cc:dd:ee:ff", CONF_TOKEN: "037739871315caef138547b03e348b72", @@ -47,7 +45,6 @@ MOCK_ENTRYDATA_WS = { CONF_NAME: "any", } MOCK_ENTRY_WS_WITH_MAC = { - CONF_IP_ADDRESS: "test", CONF_HOST: "fake_host", CONF_METHOD: "websocket", CONF_MAC: "aa:bb:cc:dd:ee:ff", diff --git a/tests/components/samsungtv/snapshots/test_diagnostics.ambr b/tests/components/samsungtv/snapshots/test_diagnostics.ambr index dd1b3654186..7650623a4fb 100644 --- a/tests/components/samsungtv/snapshots/test_diagnostics.ambr +++ b/tests/components/samsungtv/snapshots/test_diagnostics.ambr @@ -14,7 +14,6 @@ 'entry': dict({ 'data': dict({ 'host': 'fake_host', - 'ip_address': 'test', 'mac': 'aa:bb:cc:dd:ee:ff', 'method': 'websocket', 'model': '82GXARRS', @@ -47,7 +46,6 @@ 'entry': dict({ 'data': dict({ 'host': 'fake_host', - 'ip_address': 'test', 'mac': 'aa:bb:cc:dd:ee:ff', 'method': 'encrypted', 'name': 'fake', @@ -107,7 +105,6 @@ 'entry': dict({ 'data': dict({ 'host': 'fake_host', - 'ip_address': 'test', 'mac': 'aa:bb:cc:dd:ee:ff', 'method': 'encrypted', 'model': 'UE48JU6400', diff --git a/tests/components/samsungtv/test_config_flow.py b/tests/components/samsungtv/test_config_flow.py index 6eef80026f0..504eccc4f12 100644 --- a/tests/components/samsungtv/test_config_flow.py +++ b/tests/components/samsungtv/test_config_flow.py @@ -35,7 +35,6 @@ from homeassistant.components.samsungtv.const import ( from homeassistant.config_entries import ConfigEntryState from homeassistant.const import ( CONF_HOST, - CONF_IP_ADDRESS, CONF_MAC, CONF_METHOD, CONF_MODEL, @@ -89,7 +88,6 @@ MOCK_ZEROCONF_DATA = ZeroconfServiceInfo( ) MOCK_OLD_ENTRY = { CONF_HOST: "10.10.12.34", - CONF_IP_ADDRESS: EXISTING_IP, CONF_METHOD: "legacy", CONF_PORT: None, } @@ -1257,14 +1255,13 @@ async def test_autodetect_none(hass: HomeAssistant) -> None: @pytest.mark.usefixtures("remotews", "rest_api", "remoteencws_failing") async def test_update_old_entry(hass: HomeAssistant) -> None: - """Test update of old entry.""" + """Test update of old entry sets unique id.""" entry = MockConfigEntry(domain=DOMAIN, data=MOCK_OLD_ENTRY) entry.add_to_hass(hass) config_entries_domain = hass.config_entries.async_entries(DOMAIN) assert len(config_entries_domain) == 1 assert entry is config_entries_domain[0] - assert entry.data[CONF_IP_ADDRESS] == EXISTING_IP assert not entry.unique_id assert await async_setup_component(hass, DOMAIN, {}) is True @@ -1282,7 +1279,6 @@ async def test_update_old_entry(hass: HomeAssistant) -> None: entry2 = config_entries_domain[0] # check updated device info - assert entry2.data.get(CONF_IP_ADDRESS) is not None assert entry2.unique_id == "be9554b9-c9fb-41f4-8920-22da015376a4" diff --git a/tests/components/samsungtv/test_media_player.py b/tests/components/samsungtv/test_media_player.py index b4f48ed20b3..9171c49ef06 100644 --- a/tests/components/samsungtv/test_media_player.py +++ b/tests/components/samsungtv/test_media_player.py @@ -53,7 +53,6 @@ from homeassistant.const import ( ATTR_FRIENDLY_NAME, ATTR_SUPPORTED_FEATURES, CONF_HOST, - CONF_IP_ADDRESS, CONF_MAC, CONF_METHOD, CONF_MODEL, @@ -111,7 +110,6 @@ MOCK_CALLS_WS = { } MOCK_ENTRY_WS = { - CONF_IP_ADDRESS: "test", CONF_HOST: "fake_host", CONF_METHOD: "websocket", CONF_NAME: "fake",