jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename mikrotik coordinator module (#117488)

Browse Source
This commit is contained in:
epenet 2024-05-15 12:02:33 +02:00 committed by GitHub
parent 73ed49e4b7
commit 6c892b227b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.coveragerc
View File

@ -800,7 +800,7 @@ omit =
homeassistant/components/microbees/sensor.py homeassistant/components/microbees/sensor.py
homeassistant/components/microbees/switch.py homeassistant/components/microbees/switch.py
homeassistant/components/microsoft/tts.py homeassistant/components/microsoft/tts.py
homeassistant/components/mikrotik/hub.py homeassistant/components/mikrotik/coordinator.py
homeassistant/components/mill/climate.py homeassistant/components/mill/climate.py
homeassistant/components/mill/sensor.py homeassistant/components/mill/sensor.py
homeassistant/components/minio/minio_helper.py homeassistant/components/minio/minio_helper.py

2
homeassistant/components/mikrotik/__init__.py
View File

@ -7,8 +7,8 @@ from homeassistant.exceptions import ConfigEntryAuthFailed, ConfigEntryNotReady
from homeassistant.helpers import config_validation as cv, device_registry as dr from homeassistant.helpers import config_validation as cv, device_registry as dr
from .const import ATTR_MANUFACTURER, DOMAIN from .const import ATTR_MANUFACTURER, DOMAIN
from .coordinator import MikrotikDataUpdateCoordinator, get_api
from .errors import CannotConnect, LoginError from .errors import CannotConnect, LoginError
from .hub import MikrotikDataUpdateCoordinator, get_api
CONFIG_SCHEMA = cv.removed(DOMAIN, raise_if_present=False) CONFIG_SCHEMA = cv.removed(DOMAIN, raise_if_present=False)

2
homeassistant/components/mikrotik/config_flow.py
View File

@ -31,8 +31,8 @@ from .const import (
DEFAULT_NAME, DEFAULT_NAME,
DOMAIN, DOMAIN,
) )
from .coordinator import get_api
from .errors import CannotConnect, LoginError from .errors import CannotConnect, LoginError
from .hub import get_api
class MikrotikFlowHandler(ConfigFlow, domain=DOMAIN): class MikrotikFlowHandler(ConfigFlow, domain=DOMAIN):

0
homeassistant/components/mikrotik/hub.py → homeassistant/components/mikrotik/coordinator.py
View File

2
homeassistant/components/mikrotik/device_tracker.py
View File

@ -17,7 +17,7 @@ from homeassistant.helpers.update_coordinator import CoordinatorEntity
import homeassistant.util.dt as dt_util import homeassistant.util.dt as dt_util
from .const import DOMAIN from .const import DOMAIN
from .hub import Device, MikrotikDataUpdateCoordinator from .coordinator import Device, MikrotikDataUpdateCoordinator
async def async_setup_entry( async def async_setup_entry(

2
tests/components/mikrotik/__init__.py
View File

@ -210,7 +210,7 @@ async def setup_mikrotik_entry(hass: HomeAssistant, **kwargs: Any) -> None:
with ( with (
patch("librouteros.connect"), patch("librouteros.connect"),
patch.object(mikrotik.hub.MikrotikData, "command", new=mock_command), patch.object(mikrotik.coordinator.MikrotikData, "command", new=mock_command),
): ):
await hass.config_entries.async_setup(config_entry.entry_id) await hass.config_entries.async_setup(config_entry.entry_id)
await hass.async_block_till_done() await hass.async_block_till_done()

14
tests/components/mikrotik/test_device_tracker.py
View File

@ -82,7 +82,7 @@ async def test_device_trackers(
device_2 = hass.states.get("device_tracker.device_2") device_2 = hass.states.get("device_tracker.device_2")
assert device_2 is None assert device_2 is None
with patch.object(mikrotik.hub.MikrotikData, "command", new=mock_command): with patch.object(mikrotik.coordinator.MikrotikData, "command", new=mock_command):
# test device_2 is added after connecting to wireless network # test device_2 is added after connecting to wireless network
WIRELESS_DATA.append(DEVICE_2_WIRELESS) WIRELESS_DATA.append(DEVICE_2_WIRELESS)
@ -150,7 +150,9 @@ async def test_arp_ping_success(
) -> None: ) -> None:
"""Test arp ping devices to confirm they are connected.""" """Test arp ping devices to confirm they are connected."""
with patch.object(mikrotik.hub.MikrotikData, "do_arp_ping", return_value=True): with patch.object(
mikrotik.coordinator.MikrotikData, "do_arp_ping", return_value=True
):
await setup_mikrotik_entry(hass, arp_ping=True, force_dhcp=True) await setup_mikrotik_entry(hass, arp_ping=True, force_dhcp=True)
# test wired device_2 show as home if arp ping returns True # test wired device_2 show as home if arp ping returns True
@ -163,7 +165,9 @@ async def test_arp_ping_timeout(
hass: HomeAssistant, mock_device_registry_devices hass: HomeAssistant, mock_device_registry_devices
) -> None: ) -> None:
"""Test arp ping timeout so devices are shown away.""" """Test arp ping timeout so devices are shown away."""
with patch.object(mikrotik.hub.MikrotikData, "do_arp_ping", return_value=False): with patch.object(
mikrotik.coordinator.MikrotikData, "do_arp_ping", return_value=False
):
await setup_mikrotik_entry(hass, arp_ping=True, force_dhcp=True) await setup_mikrotik_entry(hass, arp_ping=True, force_dhcp=True)
# test wired device_2 show as not_home if arp ping times out # test wired device_2 show as not_home if arp ping times out
@ -262,7 +266,9 @@ async def test_update_failed(hass: HomeAssistant, mock_device_registry_devices)
await setup_mikrotik_entry(hass) await setup_mikrotik_entry(hass)
with patch.object( with patch.object(
mikrotik.hub.MikrotikData, "command", side_effect=mikrotik.errors.CannotConnect mikrotik.coordinator.MikrotikData,
"command",
side_effect=mikrotik.errors.CannotConnect,
): ):
async_fire_time_changed(hass, utcnow() + timedelta(seconds=10)) async_fire_time_changed(hass, utcnow() + timedelta(seconds=10))
await hass.async_block_till_done(wait_background_tasks=True) await hass.async_block_till_done(wait_background_tasks=True)