jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump roombapy to 1.6.1 (#35650)

Browse Source 
* Bump roombapy to 1.6.1

* Improve roomba error handling
This commit is contained in:
Xiaonan Shen 2020-05-15 03:18:43 -07:00 committed by GitHub
parent d8c7a10fd7
commit 6d0909134c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
homeassistant/components/roomba/irobot_base.py
View File

@ -31,6 +31,7 @@ _LOGGER = logging.getLogger(__name__)
ATTR_CLEANING_TIME = "cleaning_time" ATTR_CLEANING_TIME = "cleaning_time"
ATTR_CLEANED_AREA = "cleaned_area" ATTR_CLEANED_AREA = "cleaned_area"
ATTR_ERROR = "error" ATTR_ERROR = "error"
ATTR_ERROR_CODE = "error_code"
ATTR_POSITION = "position" ATTR_POSITION = "position"
ATTR_SOFTWARE_VERSION = "software_version" ATTR_SOFTWARE_VERSION = "software_version"
@ -174,11 +175,6 @@ class IRobotVacuum(IRobotEntity, StateVacuumEntity):
# Roomba software version # Roomba software version
software_version = state.get("softwareVer") software_version = state.get("softwareVer")
# Error message in plain english
error_msg = "None"
if hasattr(self.vacuum, "error_message"):
error_msg = self.vacuum.error_message
# Set properties that are to appear in the GUI # Set properties that are to appear in the GUI
state_attrs = {ATTR_SOFTWARE_VERSION: software_version} state_attrs = {ATTR_SOFTWARE_VERSION: software_version}
@ -198,9 +194,10 @@ class IRobotVacuum(IRobotEntity, StateVacuumEntity):
state_attrs[ATTR_CLEANING_TIME] = cleaning_time state_attrs[ATTR_CLEANING_TIME] = cleaning_time
state_attrs[ATTR_CLEANED_AREA] = cleaned_area state_attrs[ATTR_CLEANED_AREA] = cleaned_area
# Skip error attr if there is none # Error
if error_msg and error_msg != "None": if self.vacuum.error_code != 0:
state_attrs[ATTR_ERROR] = error_msg state_attrs[ATTR_ERROR] = self.vacuum.error_message
state_attrs[ATTR_ERROR_CODE] = self.vacuum.error_code
# Not all Roombas expose position data # Not all Roombas expose position data
# https://github.com/koalazak/dorita980/issues/48 # https://github.com/koalazak/dorita980/issues/48

2
homeassistant/components/roomba/manifest.json
View File

@ -3,7 +3,7 @@
"name": "iRobot Roomba", "name": "iRobot Roomba",
"config_flow": true, "config_flow": true,
"documentation": "https://www.home-assistant.io/integrations/roomba", "documentation": "https://www.home-assistant.io/integrations/roomba",
"requirements": ["roombapy==1.5.3"], "requirements": ["roombapy==1.6.1"],
"dependencies": [], "dependencies": [],
"codeowners": ["@pschmitt", "@cyr-ius", "@shenxn"] "codeowners": ["@pschmitt", "@cyr-ius", "@shenxn"]
} }

2
requirements_all.txt
View File

@ -1871,7 +1871,7 @@ rocketchat-API==0.6.1
rokuecp==0.4.0 rokuecp==0.4.0
# homeassistant.components.roomba # homeassistant.components.roomba
roombapy==1.5.3 roombapy==1.6.1
# homeassistant.components.rova # homeassistant.components.rova
rova==0.1.0 rova==0.1.0

2
requirements_test_all.txt
View File

@ -765,7 +765,7 @@ ring_doorbell==0.6.0
rokuecp==0.4.0 rokuecp==0.4.0
# homeassistant.components.roomba # homeassistant.components.roomba
roombapy==1.5.3 roombapy==1.6.1
# homeassistant.components.yamaha # homeassistant.components.yamaha
rxv==0.6.0 rxv==0.6.0