jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-10 06:47:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't wait until final position of Velux cover is reached (#21558)

Browse Source 
## Description:

* Bump version to latest version of pyvlx: 0.2.10. Library more failure tolerant, when detecting an unsupported device.
* When calling API (e.g. run scene, change position) don't wait until device has reached target position (This caused  HASS to be flaky while the device was moving)
* Support for vertical and horizontal awnings.
This commit is contained in:
Julius Mittenzwei 2019-03-10 11:47:22 +01:00 committed by Robbie Trencheny
parent 7102e82113
commit 6f77d9bc34
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/velux/__init__.py
View File

@ -12,7 +12,7 @@ DATA_VELUX = "data_velux"
SUPPORTED_DOMAINS = ['cover', 'scene'] SUPPORTED_DOMAINS = ['cover', 'scene']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
REQUIREMENTS = ['pyvlx==0.2.9'] REQUIREMENTS = ['pyvlx==0.2.10']
CONFIG_SCHEMA = vol.Schema({ CONFIG_SCHEMA = vol.Schema({
DOMAIN: vol.Schema({ DOMAIN: vol.Schema({

9
homeassistant/components/velux/cover.py
View File

@ -71,11 +71,11 @@ class VeluxCover(CoverDevice):
async def async_close_cover(self, **kwargs): async def async_close_cover(self, **kwargs):
"""Close the cover.""" """Close the cover."""
await self.node.close() await self.node.close(wait_for_completion=False)
async def async_open_cover(self, **kwargs): async def async_open_cover(self, **kwargs):
"""Open the cover.""" """Open the cover."""
await self.node.open() await self.node.open(wait_for_completion=False)
async def async_set_cover_position(self, **kwargs): async def async_set_cover_position(self, **kwargs):
"""Move the cover to a specific position.""" """Move the cover to a specific position."""
@ -83,8 +83,9 @@ class VeluxCover(CoverDevice):
position_percent = 100 - kwargs[ATTR_POSITION] position_percent = 100 - kwargs[ATTR_POSITION]
from pyvlx import Position from pyvlx import Position
await self.node.set_position( await self.node.set_position(
Position(position_percent=position_percent)) Position(position_percent=position_percent),
wait_for_completion=False)
async def async_stop_cover(self, **kwargs): async def async_stop_cover(self, **kwargs):
"""Stop the cover.""" """Stop the cover."""
await self.node.stop() await self.node.stop(wait_for_completion=False)

2
homeassistant/components/velux/scene.py
View File

@ -29,4 +29,4 @@ class VeluxScene(Scene):
async def async_activate(self): async def async_activate(self):
"""Activate the scene.""" """Activate the scene."""
await self.scene.run() await self.scene.run(wait_for_completion=False)

2
requirements_all.txt
View File

@ -1457,7 +1457,7 @@ pyvesync_v2==0.9.6
pyvizio==0.0.4 pyvizio==0.0.4
# homeassistant.components.velux # homeassistant.components.velux
pyvlx==0.2.9 pyvlx==0.2.10
# homeassistant.components.notify.html5 # homeassistant.components.notify.html5
pywebpush==1.6.0 pywebpush==1.6.0