From 6f7cb158d84c9de476911531e186d53d9217384b Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Tue, 11 Oct 2022 10:40:10 +0200 Subject: [PATCH] Cleanup blockchain sensor (#80077) --- .strict-typing | 1 + homeassistant/components/blockchain/sensor.py | 16 ++++++---------- mypy.ini | 10 ++++++++++ 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/.strict-typing b/.strict-typing index 1322adf99e1..623653ac203 100644 --- a/.strict-typing +++ b/.strict-typing @@ -66,6 +66,7 @@ homeassistant.components.backup.* homeassistant.components.baf.* homeassistant.components.bayesian.* homeassistant.components.binary_sensor.* +homeassistant.components.blockchain.* homeassistant.components.bluetooth.* homeassistant.components.bluetooth_tracker.* homeassistant.components.bmw_connected_drive.* diff --git a/homeassistant/components/blockchain/sensor.py b/homeassistant/components/blockchain/sensor.py index 4feb7a9fa6a..6c65987ef57 100644 --- a/homeassistant/components/blockchain/sensor.py +++ b/homeassistant/components/blockchain/sensor.py @@ -8,7 +8,7 @@ from pyblockchain import get_balance, validate_address import voluptuous as vol from homeassistant.components.sensor import PLATFORM_SCHEMA, SensorEntity -from homeassistant.const import ATTR_ATTRIBUTION, CONF_NAME +from homeassistant.const import CONF_NAME from homeassistant.core import HomeAssistant import homeassistant.helpers.config_validation as cv from homeassistant.helpers.entity_platform import AddEntitiesCallback @@ -16,14 +16,10 @@ from homeassistant.helpers.typing import ConfigType, DiscoveryInfoType _LOGGER = logging.getLogger(__name__) -ATTRIBUTION = "Data provided by blockchain.com" - CONF_ADDRESSES = "addresses" DEFAULT_NAME = "Bitcoin Balance" -ICON = "mdi:currency-btc" - SCAN_INTERVAL = timedelta(minutes=5) PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend( @@ -42,8 +38,8 @@ def setup_platform( ) -> None: """Set up the Blockchain.com sensors.""" - addresses = config[CONF_ADDRESSES] - name = config[CONF_NAME] + addresses: list[str] = config[CONF_ADDRESSES] + name: str = config[CONF_NAME] for address in addresses: if not validate_address(address): @@ -56,11 +52,11 @@ def setup_platform( class BlockchainSensor(SensorEntity): """Representation of a Blockchain.com sensor.""" - _attr_extra_state_attributes = {ATTR_ATTRIBUTION: ATTRIBUTION} - _attr_icon = ICON + _attr_attribution = "Data provided by blockchain.com" + _attr_icon = "mdi:currency-btc" _attr_native_unit_of_measurement = "BTC" - def __init__(self, name, addresses): + def __init__(self, name: str, addresses: list[str]) -> None: """Initialize the sensor.""" self._attr_name = name self.addresses = addresses diff --git a/mypy.ini b/mypy.ini index 63e35c3076e..7e5133f38e9 100644 --- a/mypy.ini +++ b/mypy.ini @@ -412,6 +412,16 @@ disallow_untyped_defs = true warn_return_any = true warn_unreachable = true +[mypy-homeassistant.components.blockchain.*] +check_untyped_defs = true +disallow_incomplete_defs = true +disallow_subclassing_any = true +disallow_untyped_calls = true +disallow_untyped_decorators = true +disallow_untyped_defs = true +warn_return_any = true +warn_unreachable = true + [mypy-homeassistant.components.bluetooth.*] check_untyped_defs = true disallow_incomplete_defs = true