jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 08:07:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add guards for missing value in binary_sensor platform of zwave_js integration (#46293)

Browse Source
This commit is contained in:
Marcel van der Veldt 2021-02-10 16:30:16 +01:00 committed by Franck Nijhof
parent 1c2f72a453
commit 70af3e4776
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
homeassistant/components/zwave_js/binary_sensor.py
View File

@ -258,8 +258,10 @@ class ZWaveBooleanBinarySensor(ZWaveBaseEntity, BinarySensorEntity):
"""Representation of a Z-Wave binary_sensor.""" """Representation of a Z-Wave binary_sensor."""
@property @property
def is_on(self) -> bool: def is_on(self) -> Optional[bool]:
"""Return if the sensor is on or off.""" """Return if the sensor is on or off."""
if self.info.primary_value.value is None:
return None
return bool(self.info.primary_value.value) return bool(self.info.primary_value.value)
@property @property
@ -301,8 +303,10 @@ class ZWaveNotificationBinarySensor(ZWaveBaseEntity, BinarySensorEntity):
self._mapping_info = self._get_sensor_mapping() self._mapping_info = self._get_sensor_mapping()
@property @property
def is_on(self) -> bool: def is_on(self) -> Optional[bool]:
"""Return if the sensor is on or off.""" """Return if the sensor is on or off."""
if self.info.primary_value.value is None:
return None
return int(self.info.primary_value.value) == int(self.state_key) return int(self.info.primary_value.value) == int(self.state_key)
@property @property
@ -349,8 +353,10 @@ class ZWavePropertyBinarySensor(ZWaveBaseEntity, BinarySensorEntity):
self._mapping_info = self._get_sensor_mapping() self._mapping_info = self._get_sensor_mapping()
@property @property
def is_on(self) -> bool: def is_on(self) -> Optional[bool]:
"""Return if the sensor is on or off.""" """Return if the sensor is on or off."""
if self.info.primary_value.value is None:
return None
return self.info.primary_value.value in self._mapping_info["on_states"] return self.info.primary_value.value in self._mapping_info["on_states"]
@property @property