From 71230f1f1ce0fa5e06ba259a2e657eb1db01ef44 Mon Sep 17 00:00:00 2001 From: Brett Adams Date: Mon, 25 Oct 2021 22:14:41 +1000 Subject: [PATCH] Advantage Air fix logic for motion sensors (#58376) * Check correct value for motion * Update fixture for motion * Small cleanup in fixture --- homeassistant/components/advantage_air/binary_sensor.py | 2 +- tests/fixtures/advantage_air/getSystemData.json | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/advantage_air/binary_sensor.py b/homeassistant/components/advantage_air/binary_sensor.py index 1403458bc12..a7d7308d78c 100644 --- a/homeassistant/components/advantage_air/binary_sensor.py +++ b/homeassistant/components/advantage_air/binary_sensor.py @@ -67,7 +67,7 @@ class AdvantageAirZoneMotion(AdvantageAirEntity, BinarySensorEntity): @property def is_on(self): """Return if motion is detect.""" - return self._zone["motion"] + return self._zone["motion"] == 20 class AdvantageAirZoneMyZone(AdvantageAirEntity, BinarySensorEntity): diff --git a/tests/fixtures/advantage_air/getSystemData.json b/tests/fixtures/advantage_air/getSystemData.json index 4ed610f9649..76894cbb022 100644 --- a/tests/fixtures/advantage_air/getSystemData.json +++ b/tests/fixtures/advantage_air/getSystemData.json @@ -20,7 +20,7 @@ "maxDamper": 100, "measuredTemp": 25, "minDamper": 0, - "motion": 1, + "motion": 20, "motionConfig": 2, "name": "Zone open with Sensor", "number": 1, @@ -35,7 +35,7 @@ "maxDamper": 100, "measuredTemp": 25, "minDamper": 0, - "motion": 0, + "motion": 21, "motionConfig": 2, "name": "Zone closed with Sensor", "number": 2, @@ -50,8 +50,8 @@ "maxDamper": 100, "measuredTemp": 25, "minDamper": 0, - "motion": 1, - "motionConfig": 1, + "motion": 22, + "motionConfig": 2, "name": "Zone 3", "number": 3, "rssi": 25,