jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-14 08:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Spotify media position update value (#100044)

Browse Source 
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
This commit is contained in:
Archomeda 2023-10-20 14:00:31 +02:00 committed by GitHub
parent 25ab622b51
commit 712c061ac0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
homeassistant/components/spotify/media_player.py
View File

@ -2,7 +2,6 @@
from __future__ import annotations from __future__ import annotations
from asyncio import run_coroutine_threadsafe from asyncio import run_coroutine_threadsafe
import datetime as dt
from datetime import timedelta from datetime import timedelta
import logging import logging
from typing import Any from typing import Any
@ -27,7 +26,7 @@ from homeassistant.core import HomeAssistant, callback
from homeassistant.exceptions import HomeAssistantError from homeassistant.exceptions import HomeAssistantError
from homeassistant.helpers.device_registry import DeviceEntryType, DeviceInfo from homeassistant.helpers.device_registry import DeviceEntryType, DeviceInfo
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.util.dt import utc_from_timestamp from homeassistant.util.dt import utcnow
from . import HomeAssistantSpotifyData from . import HomeAssistantSpotifyData
from .browse_media import async_browse_media_internal from .browse_media import async_browse_media_internal
@ -199,13 +198,6 @@ class SpotifyMediaPlayer(MediaPlayerEntity):
return None return None
return self._currently_playing["progress_ms"] / 1000 return self._currently_playing["progress_ms"] / 1000
@property
def media_position_updated_at(self) -> dt.datetime | None:
"""When was the position of the current playing media valid."""
if not self._currently_playing:
return None
return utc_from_timestamp(self._currently_playing["timestamp"] / 1000)
@property @property
def media_image_url(self) -> str | None: def media_image_url(self) -> str | None:
"""Return the media image URL.""" """Return the media image URL."""
@ -413,6 +405,9 @@ class SpotifyMediaPlayer(MediaPlayerEntity):
additional_types=[MediaType.EPISODE] additional_types=[MediaType.EPISODE]
) )
self._currently_playing = current or {} self._currently_playing = current or {}
# Record the last updated time, because Spotify's timestamp property is unreliable
# and doesn't actually return the fetch time as is mentioned in the API description
self._attr_media_position_updated_at = utcnow() if current is not None else None
context = self._currently_playing.get("context") or {} context = self._currently_playing.get("context") or {}