From 73ed49e4b7b536a4de3ff8d294f3e17bd59a744d Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Wed, 15 May 2024 11:51:14 +0200 Subject: [PATCH] Remove ignore-wrong-coordinator-module in pylint CI (#117479) --- .github/workflows/ci.yaml | 4 ++-- pylint/plugins/hass_enforce_coordinator_module.py | 15 --------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 63473516efe..08bbafe2908 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -611,14 +611,14 @@ jobs: run: | . venv/bin/activate python --version - pylint --ignore-missing-annotations=y --ignore-wrong-coordinator-module=y homeassistant + pylint --ignore-missing-annotations=y homeassistant - name: Run pylint (partially) if: needs.info.outputs.test_full_suite == 'false' shell: bash run: | . venv/bin/activate python --version - pylint --ignore-missing-annotations=y --ignore-wrong-coordinator-module=y homeassistant/components/${{ needs.info.outputs.integrations_glob }} + pylint --ignore-missing-annotations=y homeassistant/components/${{ needs.info.outputs.integrations_glob }} mypy: name: Check mypy diff --git a/pylint/plugins/hass_enforce_coordinator_module.py b/pylint/plugins/hass_enforce_coordinator_module.py index 924b69f1b86..7160a25085d 100644 --- a/pylint/plugins/hass_enforce_coordinator_module.py +++ b/pylint/plugins/hass_enforce_coordinator_module.py @@ -19,24 +19,9 @@ class HassEnforceCoordinatorModule(BaseChecker): "Used when derived data update coordinator should be placed in its own module.", ), } - options = ( - ( - "ignore-wrong-coordinator-module", - { - "default": False, - "type": "yn", - "metavar": "", - "help": "Set to ``no`` if you wish to check if derived data update coordinator " - "is placed in its own module.", - }, - ), - ) def visit_classdef(self, node: nodes.ClassDef) -> None: """Check if derived data update coordinator is placed in its own module.""" - if self.linter.config.ignore_wrong_coordinator_module: - return - root_name = node.root().name # we only want to check component update coordinators