jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-17 10:17:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace strings with constants in Bang & Olufsen testing (#125423)

Browse Source 
Replace strings with constants in service calls
This commit is contained in:
Markus Jacobsen 2024-09-06 18:09:43 +02:00 committed by GitHub
parent ee59303d3c
commit 741add0666
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 58 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

104
tests/components/bang_olufsen/test_media_player.py
View File

@ -36,6 +36,18 @@ from homeassistant.components.media_player import (
ATTR_MEDIA_TRACK, ATTR_MEDIA_TRACK,
ATTR_MEDIA_VOLUME_LEVEL, ATTR_MEDIA_VOLUME_LEVEL,
ATTR_MEDIA_VOLUME_MUTED, ATTR_MEDIA_VOLUME_MUTED,
DOMAIN as MEDIA_PLAYER_DOMAIN,
SERVICE_CLEAR_PLAYLIST,
SERVICE_MEDIA_NEXT_TRACK,
SERVICE_MEDIA_PLAY_PAUSE,
SERVICE_MEDIA_PREVIOUS_TRACK,
SERVICE_MEDIA_SEEK,
SERVICE_MEDIA_STOP,
SERVICE_PLAY_MEDIA,
SERVICE_SELECT_SOURCE,
SERVICE_TURN_OFF,
SERVICE_VOLUME_MUTE,
SERVICE_VOLUME_SET,
MediaPlayerState, MediaPlayerState,
MediaType, MediaType,
) )
@ -385,8 +397,8 @@ async def test_async_turn_off(
) )
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"turn_off", SERVICE_TURN_OFF,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -416,8 +428,8 @@ async def test_async_set_volume_level(
assert ATTR_MEDIA_VOLUME_LEVEL not in states.attributes assert ATTR_MEDIA_VOLUME_LEVEL not in states.attributes
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"volume_set", SERVICE_VOLUME_SET,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_VOLUME_LEVEL: TEST_VOLUME_HOME_ASSISTANT_FORMAT, ATTR_MEDIA_VOLUME_LEVEL: TEST_VOLUME_HOME_ASSISTANT_FORMAT,
@ -454,8 +466,8 @@ async def test_async_mute_volume(
assert ATTR_MEDIA_VOLUME_MUTED not in states.attributes assert ATTR_MEDIA_VOLUME_MUTED not in states.attributes
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"volume_mute", SERVICE_VOLUME_MUTE,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_VOLUME_MUTED: TEST_VOLUME_HOME_ASSISTANT_FORMAT, ATTR_MEDIA_VOLUME_MUTED: TEST_VOLUME_HOME_ASSISTANT_FORMAT,
@ -509,8 +521,8 @@ async def test_async_media_play_pause(
assert states.state == BANG_OLUFSEN_STATES[initial_state.value] assert states.state == BANG_OLUFSEN_STATES[initial_state.value]
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"media_play_pause", SERVICE_MEDIA_PLAY_PAUSE,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -539,8 +551,8 @@ async def test_async_media_stop(
assert states.state == BANG_OLUFSEN_STATES[TEST_PLAYBACK_STATE_PLAYING.value] assert states.state == BANG_OLUFSEN_STATES[TEST_PLAYBACK_STATE_PLAYING.value]
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"media_stop", SERVICE_MEDIA_STOP,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -560,8 +572,8 @@ async def test_async_media_next_track(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"media_next_track", SERVICE_MEDIA_NEXT_TRACK,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -601,8 +613,8 @@ async def test_async_media_seek(
# Check results # Check results
with expected_result: with expected_result:
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"media_seek", SERVICE_MEDIA_SEEK,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_SEEK_POSITION: TEST_SEEK_POSITION_HOME_ASSISTANT_FORMAT, ATTR_MEDIA_SEEK_POSITION: TEST_SEEK_POSITION_HOME_ASSISTANT_FORMAT,
@ -624,8 +636,8 @@ async def test_async_media_previous_track(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"media_previous_track", SERVICE_MEDIA_PREVIOUS_TRACK,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -644,8 +656,8 @@ async def test_async_clear_playlist(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"clear_playlist", SERVICE_CLEAR_PLAYLIST,
{ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID}, {ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID},
blocking=True, blocking=True,
) )
@ -680,8 +692,8 @@ async def test_async_select_source(
with expected_result: with expected_result:
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"select_source", SERVICE_SELECT_SOURCE,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_INPUT_SOURCE: source, ATTR_INPUT_SOURCE: source,
@ -705,8 +717,8 @@ async def test_async_play_media_invalid_type(
with pytest.raises(ServiceValidationError) as exc_info: with pytest.raises(ServiceValidationError) as exc_info:
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "test", ATTR_MEDIA_CONTENT_ID: "test",
@ -734,8 +746,8 @@ async def test_async_play_media_url(
await async_setup_component(hass, "media_source", {"media_source": {}}) await async_setup_component(hass, "media_source", {"media_source": {}})
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3", ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3",
@ -760,8 +772,8 @@ async def test_async_play_media_overlay_absolute_volume_uri(
await async_setup_component(hass, "media_source", {"media_source": {}}) await async_setup_component(hass, "media_source", {"media_source": {}})
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3", ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3",
@ -792,8 +804,8 @@ async def test_async_play_media_overlay_invalid_offset_volume_tts(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "Dette er en test", ATTR_MEDIA_CONTENT_ID: "Dette er en test",
@ -829,8 +841,8 @@ async def test_async_play_media_overlay_offset_volume_tts(
volume_callback(TEST_VOLUME) volume_callback(TEST_VOLUME)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "This is a test", ATTR_MEDIA_CONTENT_ID: "This is a test",
@ -859,8 +871,8 @@ async def test_async_play_media_tts(
await async_setup_component(hass, "media_source", {"media_source": {}}) await async_setup_component(hass, "media_source", {"media_source": {}})
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3", ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3",
@ -883,8 +895,8 @@ async def test_async_play_media_radio(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "1234567890123456", ATTR_MEDIA_CONTENT_ID: "1234567890123456",
@ -909,8 +921,8 @@ async def test_async_play_media_favourite(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "1", ATTR_MEDIA_CONTENT_ID: "1",
@ -934,8 +946,8 @@ async def test_async_play_media_deezer_flow(
# Send a service call # Send a service call
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "flow", ATTR_MEDIA_CONTENT_ID: "flow",
@ -961,8 +973,8 @@ async def test_async_play_media_deezer_playlist(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "playlist:1234567890", ATTR_MEDIA_CONTENT_ID: "playlist:1234567890",
@ -988,8 +1000,8 @@ async def test_async_play_media_deezer_track(
await hass.config_entries.async_setup(mock_config_entry.entry_id) await hass.config_entries.async_setup(mock_config_entry.entry_id)
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "1234567890", ATTR_MEDIA_CONTENT_ID: "1234567890",
@ -1017,8 +1029,8 @@ async def test_async_play_media_invalid_deezer(
with pytest.raises(HomeAssistantError) as exc_info: with pytest.raises(HomeAssistantError) as exc_info:
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "flow", ATTR_MEDIA_CONTENT_ID: "flow",
@ -1054,8 +1066,8 @@ async def test_async_play_media_url_m3u(
), ),
): ):
await hass.services.async_call( await hass.services.async_call(
"media_player", MEDIA_PLAYER_DOMAIN,
"play_media", SERVICE_PLAY_MEDIA,
{ {
ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID, ATTR_ENTITY_ID: TEST_MEDIA_PLAYER_ENTITY_ID,
ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3", ATTR_MEDIA_CONTENT_ID: "media-source://media_source/local/doorbell.mp3",