Clean up constants (#46885)

homeassistant/components/air_quality/__init__.py

@@ -2,7 +2,10 @@
 from datetime import timedelta
 import logging
 
-from homeassistant.const import CONCENTRATION_MICROGRAMS_PER_CUBIC_METER
+from homeassistant.const import (
+    ATTR_ATTRIBUTION,
+    CONCENTRATION_MICROGRAMS_PER_CUBIC_METER,
+)
 from homeassistant.helpers.config_validation import (  # noqa: F401
     PLATFORM_SCHEMA,
     PLATFORM_SCHEMA_BASE,
@@ -13,7 +16,6 @@ from homeassistant.helpers.entity_component import EntityComponent
 _LOGGER = logging.getLogger(__name__)
 
 ATTR_AQI = "air_quality_index"
-ATTR_ATTRIBUTION = "attribution"
 ATTR_CO2 = "carbon_dioxide"
 ATTR_CO = "carbon_monoxide"
 ATTR_N2O = "nitrogen_oxide"

homeassistant/components/channels/media_player.py

@@ -18,6 +18,7 @@ from homeassistant.components.media_player.const import (
     SUPPORT_VOLUME_MUTE,
 )
 from homeassistant.const import (
+    ATTR_SECONDS,
     CONF_HOST,
     CONF_NAME,
     CONF_PORT,
@@ -53,10 +54,6 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend(
 )
 
 
-# Service call validation schemas
-ATTR_SECONDS = "seconds"
-
-
 async def async_setup_platform(hass, config, async_add_entities, discovery_info=None):
     """Set up the Channels platform."""
     device = ChannelsPlayer(config[CONF_NAME], config[CONF_HOST], config[CONF_PORT])

homeassistant/components/comfoconnect/sensor.py

@@ -29,6 +29,7 @@ import voluptuous as vol
 from homeassistant.components.sensor import PLATFORM_SCHEMA
 from homeassistant.const import (
     ATTR_DEVICE_CLASS,
+    ATTR_ID,
     CONF_RESOURCES,
     DEVICE_CLASS_ENERGY,
     DEVICE_CLASS_HUMIDITY,
@@ -72,7 +73,6 @@ ATTR_SUPPLY_TEMPERATURE = "supply_temperature"
 _LOGGER = logging.getLogger(__name__)
 
 ATTR_ICON = "icon"
-ATTR_ID = "id"
 ATTR_LABEL = "label"
 ATTR_MULTIPLIER = "multiplier"
 ATTR_UNIT = "unit"

homeassistant/components/facebox/image_processing.py

@@ -15,6 +15,7 @@ from homeassistant.components.image_processing import (
 )
 from homeassistant.const import (
     ATTR_ENTITY_ID,
+    ATTR_ID,
     ATTR_NAME,
     CONF_IP_ADDRESS,
     CONF_PASSWORD,
@@ -34,7 +35,6 @@ _LOGGER = logging.getLogger(__name__)
 ATTR_BOUNDING_BOX = "bounding_box"
 ATTR_CLASSIFIER = "classifier"
 ATTR_IMAGE_ID = "image_id"
-ATTR_ID = "id"
 ATTR_MATCHED = "matched"
 FACEBOX_NAME = "name"
 CLASSIFIER = "facebox"

homeassistant/components/hassio/const.py

@@ -16,7 +16,6 @@ ATTR_INPUT = "input"
 ATTR_NAME = "name"
 ATTR_PANELS = "panels"
 ATTR_PASSWORD = "password"
-ATTR_SERVICE = "service"
 ATTR_SNAPSHOT = "snapshot"
 ATTR_TITLE = "title"
 ATTR_USERNAME = "username"

homeassistant/components/hassio/discovery.py

@@ -6,17 +6,10 @@ from aiohttp import web
 from aiohttp.web_exceptions import HTTPServiceUnavailable
 
 from homeassistant.components.http import HomeAssistantView
-from homeassistant.const import EVENT_HOMEASSISTANT_START
+from homeassistant.const import ATTR_SERVICE, EVENT_HOMEASSISTANT_START
 from homeassistant.core import callback
 
-from .const import (
+from .const import ATTR_ADDON, ATTR_CONFIG, ATTR_DISCOVERY, ATTR_NAME, ATTR_UUID
-    ATTR_ADDON,
-    ATTR_CONFIG,
-    ATTR_DISCOVERY,
-    ATTR_NAME,
-    ATTR_SERVICE,
-    ATTR_UUID,
-)
 from .handler import HassioAPIError
 
 _LOGGER = logging.getLogger(__name__)

homeassistant/components/homematicip_cloud/generic_entity.py

@@ -5,6 +5,7 @@ from typing import Any, Dict, Optional
 from homematicip.aio.device import AsyncDevice
 from homematicip.aio.group import AsyncGroup
 
+from homeassistant.const import ATTR_ID
 from homeassistant.core import callback
 from homeassistant.helpers import device_registry as dr, entity_registry as er
 from homeassistant.helpers.entity import Entity
@@ -19,7 +20,6 @@ ATTR_LOW_BATTERY = "low_battery"
 ATTR_CONFIG_PENDING = "config_pending"
 ATTR_CONNECTION_TYPE = "connection_type"
 ATTR_DUTY_CYCLE_REACHED = "duty_cycle_reached"
-ATTR_ID = "id"
 ATTR_IS_GROUP = "is_group"
 # RSSI HAP -> Device
 ATTR_RSSI_DEVICE = "rssi_device"

homeassistant/components/netatmo/const.py

@@ -56,7 +56,6 @@ DEFAULT_PERSON = "Unknown"
 DEFAULT_DISCOVERY = True
 DEFAULT_WEBHOOKS = False
 
-ATTR_ID = "id"
 ATTR_PSEUDO = "pseudo"
 ATTR_NAME = "name"
 ATTR_EVENT_TYPE = "event_type"

homeassistant/components/netatmo/webhook.py

@@ -1,13 +1,13 @@
 """The Netatmo integration."""
 import logging
 
+from homeassistant.const import ATTR_ID
 from homeassistant.core import callback
 from homeassistant.helpers.dispatcher import async_dispatcher_send
 
 from .const import (
     ATTR_EVENT_TYPE,
     ATTR_FACE_URL,
-    ATTR_ID,
     ATTR_IS_KNOWN,
     ATTR_NAME,
     ATTR_PERSONS,

homeassistant/components/nightscout/const.py

@@ -3,6 +3,5 @@
 DOMAIN = "nightscout"
 
 ATTR_DEVICE = "device"
-ATTR_DATE = "date"
 ATTR_DELTA = "delta"
 ATTR_DIRECTION = "direction"

homeassistant/components/nightscout/sensor.py

@@ -8,10 +8,11 @@ from aiohttp import ClientError
 from py_nightscout import Api as NightscoutAPI
 
 from homeassistant.config_entries import ConfigEntry
+from homeassistant.const import ATTR_DATE
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity import Entity
 
-from .const import ATTR_DATE, ATTR_DELTA, ATTR_DEVICE, ATTR_DIRECTION, DOMAIN
+from .const import ATTR_DELTA, ATTR_DEVICE, ATTR_DIRECTION, DOMAIN
 
 SCAN_INTERVAL = timedelta(minutes=1)
 

homeassistant/components/rachio/switch.py

@@ -6,7 +6,7 @@ import logging
 import voluptuous as vol
 
 from homeassistant.components.switch import SwitchEntity
-from homeassistant.const import ATTR_ENTITY_ID
+from homeassistant.const import ATTR_ENTITY_ID, ATTR_ID
 from homeassistant.core import callback
 from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers import config_validation as cv, entity_platform
@@ -67,7 +67,6 @@ from .webhooks import (
 _LOGGER = logging.getLogger(__name__)
 
 ATTR_DURATION = "duration"
-ATTR_ID = "id"
 ATTR_PERCENT = "percent"
 ATTR_SCHEDULE_SUMMARY = "Summary"
 ATTR_SCHEDULE_ENABLED = "Enabled"

homeassistant/components/reddit/sensor.py

@@ -7,6 +7,7 @@ import voluptuous as vol
 
 from homeassistant.components.sensor import PLATFORM_SCHEMA
 from homeassistant.const import (
+    ATTR_ID,
     CONF_CLIENT_ID,
     CONF_CLIENT_SECRET,
     CONF_MAXIMUM,
@@ -21,7 +22,6 @@ _LOGGER = logging.getLogger(__name__)
 CONF_SORT_BY = "sort_by"
 CONF_SUBREDDITS = "subreddits"
 
-ATTR_ID = "id"
 ATTR_BODY = "body"
 ATTR_COMMENTS_NUMBER = "comms_num"
 ATTR_CREATED = "created"

homeassistant/components/traccar/__init__.py

@@ -3,7 +3,12 @@ from aiohttp import web
 import voluptuous as vol
 
 from homeassistant.components.device_tracker import DOMAIN as DEVICE_TRACKER
-from homeassistant.const import CONF_WEBHOOK_ID, HTTP_OK, HTTP_UNPROCESSABLE_ENTITY
+from homeassistant.const import (
+    ATTR_ID,
+    CONF_WEBHOOK_ID,
+    HTTP_OK,
+    HTTP_UNPROCESSABLE_ENTITY,
+)
 from homeassistant.helpers import config_entry_flow
 import homeassistant.helpers.config_validation as cv
 from homeassistant.helpers.dispatcher import async_dispatcher_send
@@ -13,7 +18,6 @@ from .const import (
     ATTR_ALTITUDE,
     ATTR_BATTERY,
     ATTR_BEARING,
-    ATTR_ID,
     ATTR_LATITUDE,
     ATTR_LONGITUDE,
     ATTR_SPEED,

homeassistant/components/traccar/const.py

@@ -12,7 +12,6 @@ ATTR_BATTERY = "batt"
 ATTR_BEARING = "bearing"
 ATTR_CATEGORY = "category"
 ATTR_GEOFENCE = "geofence"
-ATTR_ID = "id"
 ATTR_LATITUDE = "lat"
 ATTR_LONGITUDE = "lon"
 ATTR_MOTION = "motion"

homeassistant/components/usgs_earthquakes_feed/geo_location.py

@@ -11,6 +11,7 @@ import voluptuous as vol
 from homeassistant.components.geo_location import PLATFORM_SCHEMA, GeolocationEvent
 from homeassistant.const import (
     ATTR_ATTRIBUTION,
+    ATTR_TIME,
     CONF_LATITUDE,
     CONF_LONGITUDE,
     CONF_RADIUS,
@@ -30,7 +31,6 @@ ATTR_EXTERNAL_ID = "external_id"
 ATTR_MAGNITUDE = "magnitude"
 ATTR_PLACE = "place"
 ATTR_STATUS = "status"
-ATTR_TIME = "time"
 ATTR_TYPE = "type"
 ATTR_UPDATED = "updated"
 

homeassistant/components/watson_tts/tts.py

@@ -8,7 +8,6 @@ import homeassistant.helpers.config_validation as cv
 
 CONF_URL = "watson_url"
 CONF_APIKEY = "watson_apikey"
-ATTR_CREDENTIALS = "credentials"
 
 DEFAULT_URL = "https://stream.watsonplatform.net/text-to-speech/api"
 

homeassistant/components/zwave_js/__init__.py

@@ -12,7 +12,7 @@ from zwave_js_server.model.value import ValueNotification
 
 from homeassistant.components.hassio.handler import HassioAPIError
 from homeassistant.config_entries import ConfigEntry
-from homeassistant.const import CONF_URL, EVENT_HOMEASSISTANT_STOP
+from homeassistant.const import ATTR_DOMAIN, CONF_URL, EVENT_HOMEASSISTANT_STOP
 from homeassistant.core import Event, HomeAssistant, callback
 from homeassistant.exceptions import ConfigEntryNotReady
 from homeassistant.helpers import device_registry
@@ -24,7 +24,6 @@ from .const import (
     ATTR_COMMAND_CLASS,
     ATTR_COMMAND_CLASS_NAME,
     ATTR_DEVICE_ID,
-    ATTR_DOMAIN,
     ATTR_ENDPOINT,
     ATTR_HOME_ID,
     ATTR_LABEL,

homeassistant/components/zwave_js/const.py

@@ -28,7 +28,6 @@ ATTR_VALUE = "value"
 ATTR_COMMAND_CLASS = "command_class"
 ATTR_COMMAND_CLASS_NAME = "command_class_name"
 ATTR_TYPE = "type"
-ATTR_DOMAIN = "domain"
 ATTR_DEVICE_ID = "device_id"
 ATTR_PROPERTY_NAME = "property_name"
 ATTR_PROPERTY_KEY_NAME = "property_key_name"

tests/components/dynalite/common.py

@@ -2,11 +2,11 @@
 from unittest.mock import AsyncMock, Mock, call, patch
 
 from homeassistant.components import dynalite
+from homeassistant.const import ATTR_SERVICE
 from homeassistant.helpers import entity_registry
 
 from tests.common import MockConfigEntry
 
-ATTR_SERVICE = "service"
 ATTR_METHOD = "method"
 ATTR_ARGS = "args"
 

tests/components/nightscout/test_sensor.py

@@ -1,12 +1,11 @@
 """The sensor tests for the Nightscout platform."""
 
 from homeassistant.components.nightscout.const import (
-    ATTR_DATE,
     ATTR_DELTA,
     ATTR_DEVICE,
     ATTR_DIRECTION,
 )
-from homeassistant.const import ATTR_ICON, STATE_UNAVAILABLE
+from homeassistant.const import ATTR_DATE, ATTR_ICON, STATE_UNAVAILABLE
 
 from tests.components.nightscout import (
     GLUCOSE_READINGS,