jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 14:17:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure all data is set in seventeentrack before adding entities (#111603)

Browse Source 
This integration would call async_add_entities before
it has set the data that the entity needed. There is
no guarantee that the entity would take long enough
to add that the data would be there
This commit is contained in:
J. Nick Koston 2024-02-27 03:47:31 -10:00 committed by GitHub
parent 08e0008d31
commit 773543b617
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
homeassistant/components/seventeentrack/sensor.py
View File

@ -21,6 +21,7 @@ from homeassistant.core import HomeAssistant
from homeassistant.helpers import ( from homeassistant.helpers import (
aiohttp_client, aiohttp_client,
config_validation as cv, config_validation as cv,
entity,
entity_registry as er, entity_registry as er,
) )
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
@ -293,6 +294,7 @@ class SeventeenTrackData:
async def _async_update(self): async def _async_update(self):
"""Get updated data from 17track.net.""" """Get updated data from 17track.net."""
entities: list[entity.Entity] = []
try: try:
packages = await self._client.profile.packages( packages = await self._client.profile.packages(
@ -306,12 +308,9 @@ class SeventeenTrackData:
_LOGGER.debug("Will add new tracking numbers: %s", to_add) _LOGGER.debug("Will add new tracking numbers: %s", to_add)
if to_add: if to_add:
self._async_add_entities( entities.extend(
[
SeventeenTrackPackageSensor(self, new_packages[tracking_number]) SeventeenTrackPackageSensor(self, new_packages[tracking_number])
for tracking_number in to_add for tracking_number in to_add
],
True,
) )
self.packages = new_packages self.packages = new_packages
@ -327,15 +326,13 @@ class SeventeenTrackData:
# creating summary sensors on first update # creating summary sensors on first update
if self.first_update: if self.first_update:
self.first_update = False self.first_update = False
entities.extend(
self._async_add_entities(
[
SeventeenTrackSummarySensor(self, status, quantity) SeventeenTrackSummarySensor(self, status, quantity)
for status, quantity in self.summary.items() for status, quantity in self.summary.items()
],
True,
) )
except SeventeenTrackError as err: except SeventeenTrackError as err:
_LOGGER.error("There was an error retrieving the summary: %s", err) _LOGGER.error("There was an error retrieving the summary: %s", err)
self.summary = {} self.summary = {}
self._async_add_entities(entities, True)