jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 16:17:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix script logging with name (#33120)

Browse Source
This commit is contained in:
Paulus Schoutsen 2020-03-22 05:29:50 -07:00 committed by Pascal Vizeli
parent 95de94e53f
commit 7a6ac578b4
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/helpers/script.py
View File

@ -701,7 +701,9 @@ class Script:
def _log(self, msg, *args, level=logging.INFO): def _log(self, msg, *args, level=logging.INFO):
if self.name: if self.name:
msg = f"{self.name}: {msg}" msg = f"%s: {msg}"
args = [self.name, *args]
if level == _LOG_EXCEPTION: if level == _LOG_EXCEPTION:
self._logger.exception(msg, *args) self._logger.exception(msg, *args)
else: else:

12
tests/helpers/test_script.py
View File

@ -1743,3 +1743,15 @@ async def test_if_running_parallel(hass):
assert len(events) == 4 assert len(events) == 4
assert events[2].data["value"] == 2 assert events[2].data["value"] == 2
assert events[3].data["value"] == 2 assert events[3].data["value"] == 2
async def test_script_logging(caplog):
"""Test script logging."""
script_obj = script.Script(None, [], "Script with % Name")
script_obj._log("Test message with name %s", 1)
assert "Script with % Name: Test message with name 1" in caplog.text
script_obj = script.Script(None, [])
script_obj._log("Test message without name %s", 2)
assert "Test message without name 2" in caplog.text