jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 12:47:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address late review of nina (#79467)

Browse Source 
* Address review

* Remove unused attribute
This commit is contained in:
Maximilian 2022-10-02 17:57:32 +02:00 committed by GitHub
parent 547a63e314
commit 7aacdec8e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
homeassistant/components/nina/__init__.py
View File

@ -2,7 +2,6 @@
from __future__ import annotations from __future__ import annotations
from dataclasses import dataclass from dataclasses import dataclass
from typing import Any
from async_timeout import timeout from async_timeout import timeout
from pynina import ApiError, Nina from pynina import ApiError, Nina
@ -63,7 +62,9 @@ class NinaWarningData:
is_valid: bool is_valid: bool
class NINADataUpdateCoordinator(DataUpdateCoordinator): class NINADataUpdateCoordinator(
DataUpdateCoordinator[dict[str, list[NinaWarningData]]]
):
"""Class to manage fetching NINA data API.""" """Class to manage fetching NINA data API."""
def __init__( def __init__(
@ -72,7 +73,6 @@ class NINADataUpdateCoordinator(DataUpdateCoordinator):
"""Initialize.""" """Initialize."""
self._regions: dict[str, str] = regions self._regions: dict[str, str] = regions
self._nina: Nina = Nina(async_get_clientsession(hass)) self._nina: Nina = Nina(async_get_clientsession(hass))
self.warnings: dict[str, Any] = {}
self.corona_filter: bool = corona_filter self.corona_filter: bool = corona_filter
for region in regions: for region in regions:
@ -80,7 +80,7 @@ class NINADataUpdateCoordinator(DataUpdateCoordinator):
super().__init__(hass, _LOGGER, name=DOMAIN, update_interval=SCAN_INTERVAL) super().__init__(hass, _LOGGER, name=DOMAIN, update_interval=SCAN_INTERVAL)
async def _async_update_data(self) -> dict[str, Any]: async def _async_update_data(self) -> dict[str, list[NinaWarningData]]:
"""Update data.""" """Update data."""
async with timeout(10): async with timeout(10):
try: try:
@ -89,10 +89,10 @@ class NINADataUpdateCoordinator(DataUpdateCoordinator):
raise UpdateFailed(err) from err raise UpdateFailed(err) from err
return self._parse_data() return self._parse_data()
def _parse_data(self) -> dict[str, Any]: def _parse_data(self) -> dict[str, list[NinaWarningData]]:
"""Parse warning data.""" """Parse warning data."""
return_data: dict[str, Any] = {} return_data: dict[str, list[NinaWarningData]] = {}
for region_id, raw_warnings in self._nina.warnings.items(): for region_id, raw_warnings in self._nina.warnings.items():
warnings_for_regions: list[NinaWarningData] = [] warnings_for_regions: list[NinaWarningData] = []

6
homeassistant/components/nina/binary_sensor.py
View File

@ -12,7 +12,7 @@ from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.update_coordinator import CoordinatorEntity from homeassistant.helpers.update_coordinator import CoordinatorEntity
from . import NINADataUpdateCoordinator, NinaWarningData from . import NINADataUpdateCoordinator
from .const import ( from .const import (
ATTR_DESCRIPTION, ATTR_DESCRIPTION,
ATTR_EXPIRES, ATTR_EXPIRES,
@ -75,7 +75,7 @@ class NINAMessage(CoordinatorEntity[NINADataUpdateCoordinator], BinarySensorEnti
if not len(self.coordinator.data[self._region]) > self._warning_index: if not len(self.coordinator.data[self._region]) > self._warning_index:
return False return False
data: NinaWarningData = self.coordinator.data[self._region][self._warning_index] data = self.coordinator.data[self._region][self._warning_index]
return data.is_valid return data.is_valid
@ -85,7 +85,7 @@ class NINAMessage(CoordinatorEntity[NINADataUpdateCoordinator], BinarySensorEnti
if not self.is_on: if not self.is_on:
return {} return {}
data: NinaWarningData = self.coordinator.data[self._region][self._warning_index] data = self.coordinator.data[self._region][self._warning_index]
return { return {
ATTR_HEADLINE: data.headline, ATTR_HEADLINE: data.headline,