jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 17:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix uptime floating values for Vodafone Station (#128974)

Browse Source
This commit is contained in:
Simone Chemelli 2024-10-25 11:25:27 +02:00 committed by GitHub
parent 267e1dd0f8
commit 7b1d6ddcf6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 32 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
homeassistant/components/vodafone_station/sensor.py
View File

@ -23,25 +23,42 @@ from .const import _LOGGER, DOMAIN, LINE_TYPES
from .coordinator import VodafoneStationRouter from .coordinator import VodafoneStationRouter
NOT_AVAILABLE: list = ["", "N/A", "0.0.0.0"] NOT_AVAILABLE: list = ["", "N/A", "0.0.0.0"]
UPTIME_DEVIATION = 30
@dataclass(frozen=True, kw_only=True) @dataclass(frozen=True, kw_only=True)
class VodafoneStationEntityDescription(SensorEntityDescription): class VodafoneStationEntityDescription(SensorEntityDescription):
"""Vodafone Station entity description.""" """Vodafone Station entity description."""
value: Callable[[Any, Any], Any] = ( value: Callable[[Any, Any, Any], Any] = (
lambda coordinator, key: coordinator.data.sensors[key] lambda coordinator, last_value, key: coordinator.data.sensors[key]
) )
is_suitable: Callable[[dict], bool] = lambda val: True is_suitable: Callable[[dict], bool] = lambda val: True
def _calculate_uptime(coordinator: VodafoneStationRouter, key: str) -> datetime: def _calculate_uptime(
coordinator: VodafoneStationRouter,
last_value: datetime | None,
key: str,
) -> datetime:
"""Calculate device uptime.""" """Calculate device uptime."""
return coordinator.api.convert_uptime(coordinator.data.sensors[key]) delta_uptime = coordinator.api.convert_uptime(coordinator.data.sensors[key])
if (
not last_value
or abs((delta_uptime - last_value).total_seconds()) > UPTIME_DEVIATION
):
return delta_uptime
return last_value
def _line_connection(coordinator: VodafoneStationRouter, key: str) -> str | None: def _line_connection(
coordinator: VodafoneStationRouter,
last_value: str | None,
key: str,
) -> str | None:
"""Identify line type.""" """Identify line type."""
value = coordinator.data.sensors value = coordinator.data.sensors
@ -126,14 +143,18 @@ SENSOR_TYPES: Final = (
translation_key="sys_cpu_usage", translation_key="sys_cpu_usage",
native_unit_of_measurement=PERCENTAGE, native_unit_of_measurement=PERCENTAGE,
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
value=lambda coordinator, key: float(coordinator.data.sensors[key][:-1]), value=lambda coordinator, last_value, key: float(
coordinator.data.sensors[key][:-1]
),
), ),
VodafoneStationEntityDescription( VodafoneStationEntityDescription(
key="sys_memory_usage", key="sys_memory_usage",
translation_key="sys_memory_usage", translation_key="sys_memory_usage",
native_unit_of_measurement=PERCENTAGE, native_unit_of_measurement=PERCENTAGE,
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
value=lambda coordinator, key: float(coordinator.data.sensors[key][:-1]), value=lambda coordinator, last_value, key: float(
coordinator.data.sensors[key][:-1]
),
), ),
VodafoneStationEntityDescription( VodafoneStationEntityDescription(
key="sys_reboot_cause", key="sys_reboot_cause",
@ -178,10 +199,12 @@ class VodafoneStationSensorEntity(
self.entity_description = description self.entity_description = description
self._attr_device_info = coordinator.device_info self._attr_device_info = coordinator.device_info
self._attr_unique_id = f"{coordinator.serial_number}_{description.key}" self._attr_unique_id = f"{coordinator.serial_number}_{description.key}"
self._old_state = None
@property @property
def native_value(self) -> StateType: def native_value(self) -> StateType:
"""Sensor value.""" """Sensor value."""
return self.entity_description.value( self._old_state = self.entity_description.value(
self.coordinator, self.entity_description.key self.coordinator, self._old_state, self.entity_description.key
) )
return self._old_state