From 7b70f2d83b3ff840b4016cc9c9fcc1d01dec8ab0 Mon Sep 17 00:00:00 2001
From: Michael <35783820+mib1185@users.noreply.github.com>
Date: Sat, 23 Nov 2024 17:59:41 +0100
Subject: [PATCH] Translate UpdateFailed exception in PEGELONLINE (#131380)

translate UpdateFailed exception
---
 homeassistant/components/pegel_online/coordinator.py | 8 ++++++--
 homeassistant/components/pegel_online/strings.json   | 5 +++++
 tests/components/pegel_online/test_init.py           | 9 +++++++--
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/homeassistant/components/pegel_online/coordinator.py b/homeassistant/components/pegel_online/coordinator.py
index 1802af8e05c..c8233673fde 100644
--- a/homeassistant/components/pegel_online/coordinator.py
+++ b/homeassistant/components/pegel_online/coordinator.py
@@ -7,7 +7,7 @@ from aiopegelonline import CONNECT_ERRORS, PegelOnline, Station, StationMeasurem
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
 
-from .const import MIN_TIME_BETWEEN_UPDATES
+from .const import DOMAIN, MIN_TIME_BETWEEN_UPDATES
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -33,4 +33,8 @@ class PegelOnlineDataUpdateCoordinator(DataUpdateCoordinator[StationMeasurements
         try:
             return await self.api.async_get_station_measurements(self.station.uuid)
         except CONNECT_ERRORS as err:
-            raise UpdateFailed(f"Failed to communicate with API: {err}") from err
+            raise UpdateFailed(
+                translation_domain=DOMAIN,
+                translation_key="communication_error",
+                translation_placeholders={"error": str(err)},
+            ) from err
diff --git a/homeassistant/components/pegel_online/strings.json b/homeassistant/components/pegel_online/strings.json
index e777f6169ba..b8d18e63a4f 100644
--- a/homeassistant/components/pegel_online/strings.json
+++ b/homeassistant/components/pegel_online/strings.json
@@ -48,5 +48,10 @@
         "name": "Water temperature"
       }
     }
+  },
+  "exceptions": {
+    "communication_error": {
+      "message": "Failed to communicate with API: {error}"
+    }
   }
 }
diff --git a/tests/components/pegel_online/test_init.py b/tests/components/pegel_online/test_init.py
index ee2e78af7cf..c1b8f1861c4 100644
--- a/tests/components/pegel_online/test_init.py
+++ b/tests/components/pegel_online/test_init.py
@@ -3,6 +3,7 @@
 from unittest.mock import patch
 
 from aiohttp.client_exceptions import ClientError
+import pytest
 
 from homeassistant.components.pegel_online.const import (
     CONF_STATION,
@@ -23,7 +24,9 @@ from .const import (
 from tests.common import MockConfigEntry, async_fire_time_changed
 
 
-async def test_update_error(hass: HomeAssistant) -> None:
+async def test_update_error(
+    hass: HomeAssistant, caplog: pytest.LogCaptureFixture
+) -> None:
     """Tests error during update entity."""
     entry = MockConfigEntry(
         domain=DOMAIN,
@@ -43,9 +46,11 @@ async def test_update_error(hass: HomeAssistant) -> None:
     state = hass.states.get("sensor.dresden_elbe_water_level")
     assert state
 
-    pegelonline().override_side_effect(ClientError)
+    pegelonline().override_side_effect(ClientError("Boom"))
     async_fire_time_changed(hass, utcnow() + MIN_TIME_BETWEEN_UPDATES)
     await hass.async_block_till_done()
 
+    assert "Failed to communicate with API: Boom" in caplog.text
+
     state = hass.states.get("sensor.dresden_elbe_water_level")
     assert state.state == STATE_UNAVAILABLE