jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 22:27:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Partially revert "Add more debug logging to Ping integration" (#119487)

Browse Source
This commit is contained in:
Jan-Philipp Benecke 2024-06-12 18:08:44 +02:00 committed by Franck Nijhof
parent 4eea448f9d
commit 7b809a8e55
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
homeassistant/components/ping/helpers.py
View File

@ -9,7 +9,6 @@ from typing import TYPE_CHECKING, Any
from icmplib import NameLookupError, async_ping from icmplib import NameLookupError, async_ping
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.helpers.update_coordinator import UpdateFailed
from .const import ICMP_TIMEOUT, PING_TIMEOUT from .const import ICMP_TIMEOUT, PING_TIMEOUT
@ -59,9 +58,10 @@ class PingDataICMPLib(PingData):
timeout=ICMP_TIMEOUT, timeout=ICMP_TIMEOUT,
privileged=self._privileged, privileged=self._privileged,
) )
except NameLookupError as err: except NameLookupError:
_LOGGER.debug("Error resolving host: %s", self.ip_address)
self.is_alive = False self.is_alive = False
raise UpdateFailed(f"Error resolving host: {self.ip_address}") from err return
_LOGGER.debug( _LOGGER.debug(
"async_ping returned: reachable=%s sent=%i received=%s", "async_ping returned: reachable=%s sent=%i received=%s",
@ -152,17 +152,22 @@ class PingDataSubProcess(PingData):
if TYPE_CHECKING: if TYPE_CHECKING:
assert match is not None assert match is not None
rtt_min, rtt_avg, rtt_max, rtt_mdev = match.groups() rtt_min, rtt_avg, rtt_max, rtt_mdev = match.groups()
except TimeoutError as err: except TimeoutError:
_LOGGER.debug(
"Timed out running command: `%s`, after: %s",
" ".join(self._ping_cmd),
self._count + PING_TIMEOUT,
)
if pinger: if pinger:
with suppress(TypeError): with suppress(TypeError):
await pinger.kill() # type: ignore[func-returns-value] await pinger.kill() # type: ignore[func-returns-value]
del pinger del pinger
raise UpdateFailed( return None
f"Timed out running command: `{self._ping_cmd}`, after: {self._count + PING_TIMEOUT}s"
) from err
except AttributeError as err: except AttributeError as err:
raise UpdateFailed from err _LOGGER.debug("Error matching ping output: %s", err)
return None
return {"min": rtt_min, "avg": rtt_avg, "max": rtt_max, "mdev": rtt_mdev} return {"min": rtt_min, "avg": rtt_avg, "max": rtt_max, "mdev": rtt_mdev}
async def async_update(self) -> None: async def async_update(self) -> None: