jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-20 11:47:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix zwave_js firmware update logic (#101143)

Browse Source 
* Fix zwave_js firmware update logic

* add comment

* tweak implementation for ssame outcome
This commit is contained in:
Raman Gupta 2023-09-29 23:05:33 -04:00 committed by GitHub
parent a1d632c5d1
commit 7b9c1c3953
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
homeassistant/components/zwave_js/update.py
View File

@ -211,11 +211,15 @@ class ZWaveNodeFirmwareUpdate(UpdateEntity):
return return
try: try:
available_firmware_updates = ( # Retrieve all firmware updates including non-stable ones but filter
await self.driver.controller.async_get_available_firmware_updates( # non-stable channels out
self.node, API_KEY_FIRMWARE_UPDATE_SERVICE available_firmware_updates = [
) update
for update in await self.driver.controller.async_get_available_firmware_updates(
self.node, API_KEY_FIRMWARE_UPDATE_SERVICE, True
) )
if update.channel == "stable"
]
except FailedZWaveCommand as err: except FailedZWaveCommand as err:
LOGGER.debug( LOGGER.debug(
"Failed to get firmware updates for node %s: %s", "Failed to get firmware updates for node %s: %s",

18
tests/components/zwave_js/test_update.py
View File

@ -87,6 +87,24 @@ FIRMWARE_UPDATES = {
"rfRegion": 1, "rfRegion": 1,
}, },
}, },
# This firmware update should never show because it's in the beta channel
{
"version": "999.999.999",
"changelog": "blah 3",
"channel": "beta",
"files": [
{"target": 0, "url": "https://example3.com", "integrity": "sha3"}
],
"downgrade": True,
"normalizedVersion": "999.999.999",
"device": {
"manufacturerId": 1,
"productType": 2,
"productId": 3,
"firmwareVersion": "0.4.4",
"rfRegion": 1,
},
},
] ]
} }