Separate climate platform and presentation units (#3755)

* Separate platform and presentation units in climate

* Fix unit tests

Maybe

* Fix unit tests some more

Maybe

* Rename _platform_unit_of_measurement to temperature_unit

* Fix tests for renamed attribute

homeassistant/components/climate/__init__.py

@@ -253,7 +253,7 @@ def setup(hass, config):
                     kwargs[value] = convert_temperature(
                         temp,
                         hass.config.units.temperature_unit,
-                        climate.unit_of_measurement
+                        climate.temperature_unit
                     )
                 else:
                     kwargs[value] = temp
@@ -422,7 +422,12 @@ class ClimateDevice(Entity):
 
     @property
     def unit_of_measurement(self):
-        """Return the unit of measurement."""
+        """The unit of measurement to display."""
+        return self.hass.config.units.temperature_unit
+
+    @property
+    def temperature_unit(self):
+        """The unit of measurement used by the platform."""
         raise NotImplementedError
 
     @property
@@ -556,10 +561,10 @@ class ClimateDevice(Entity):
         if temp is None or not isinstance(temp, Number):
             return temp
 
-        value = convert_temperature(temp, self.unit_of_measurement,
-                                    self.hass.config.units.temperature_unit)
+        value = convert_temperature(temp, self.temperature_unit,
+                                    self.unit_of_measurement)
 
-        if self.hass.config.units.temperature_unit is TEMP_CELSIUS:
+        if self.unit_of_measurement is TEMP_CELSIUS:
             decimal_count = 1
         else:
             # Users of fahrenheit generally expect integer units.

homeassistant/components/climate/demo.py

@@ -59,7 +59,7 @@ class DemoClimate(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return self._unit_of_measurement
 

homeassistant/components/climate/ecobee.py

@@ -105,7 +105,7 @@ class Thermostat(ClimateDevice):
         return self.thermostat['name']
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         if self.thermostat['settings']['useCelsius']:
             return TEMP_CELSIUS

homeassistant/components/climate/eq3btsmart.py

@@ -46,7 +46,7 @@ class EQ3BTSmartThermostat(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement that is used."""
         return TEMP_CELSIUS
 

homeassistant/components/climate/generic_thermostat.py

@@ -100,7 +100,7 @@ class GenericThermostat(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return self._unit
 

homeassistant/components/climate/heatmiser.py

@@ -77,7 +77,7 @@ class HeatmiserV3Thermostat(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement which this thermostat uses."""
         return TEMP_CELSIUS
 

homeassistant/components/climate/homematic.py

@@ -41,7 +41,7 @@ class HMThermostat(homematic.HMDevice, ClimateDevice):
     """Representation of a Homematic thermostat."""
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement that is used."""
         return TEMP_CELSIUS
 

homeassistant/components/climate/honeywell.py

@@ -120,7 +120,7 @@ class RoundThermostat(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return TEMP_CELSIUS
 
@@ -217,7 +217,7 @@ class HoneywellUSThermostat(ClimateDevice):
         return self._device.name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return (TEMP_CELSIUS if self._device.temperature_unit == 'C'
                 else TEMP_FAHRENHEIT)

homeassistant/components/climate/knx.py

@@ -63,7 +63,7 @@ class KNXThermostat(KNXMultiAddressDevice, ClimateDevice):
         return True
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return self._unit_of_measurement
 

homeassistant/components/climate/mysensors.py

@@ -47,7 +47,7 @@ class MySensorsHVAC(mysensors.MySensorsDeviceEntity, ClimateDevice):
         return self.gateway.optimistic
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return (TEMP_CELSIUS
                 if self.gateway.metric else TEMP_FAHRENHEIT)

homeassistant/components/climate/nest.py

@@ -68,7 +68,7 @@ class NestThermostat(ClimateDevice):
                 return location.capitalize() + '(' + name + ')'
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return TEMP_CELSIUS
 

homeassistant/components/climate/proliphix.py

@@ -69,7 +69,7 @@ class ProliphixThermostat(ClimateDevice):
         }
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return TEMP_FAHRENHEIT
 

homeassistant/components/climate/radiotherm.py

@@ -81,7 +81,7 @@ class RadioThermostat(ClimateDevice):
         return self._name
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return TEMP_FAHRENHEIT
 

homeassistant/components/climate/vera.py

@@ -93,7 +93,7 @@ class VeraThermostat(VeraDevice, ClimateDevice):
         self._state = self.vera_device.get_hvac_mode()
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         return TEMP_FAHRENHEIT
 

homeassistant/components/climate/zwave.py

@@ -209,7 +209,7 @@ class ZWaveClimate(ZWaveDeviceEntity, ClimateDevice):
         return self._swing_list
 
     @property
-    def unit_of_measurement(self):
+    def temperature_unit(self):
         """Return the unit of measurement."""
         if self._unit == 'C':
             return TEMP_CELSIUS

tests/components/climate/test_honeywell.py

@@ -264,13 +264,13 @@ class TestHoneywellRound(unittest.TestCase):
     def test_attributes(self):
         """Test the attributes."""
         self.assertEqual('House', self.round1.name)
-        self.assertEqual(TEMP_CELSIUS, self.round1.unit_of_measurement)
+        self.assertEqual(TEMP_CELSIUS, self.round1.temperature_unit)
         self.assertEqual(20, self.round1.current_temperature)
         self.assertEqual(21, self.round1.target_temperature)
         self.assertFalse(self.round1.is_away_mode_on)
 
         self.assertEqual('Hot Water', self.round2.name)
-        self.assertEqual(TEMP_CELSIUS, self.round2.unit_of_measurement)
+        self.assertEqual(TEMP_CELSIUS, self.round2.temperature_unit)
         self.assertEqual(21, self.round2.current_temperature)
         self.assertEqual(None, self.round2.target_temperature)
         self.assertFalse(self.round2.is_away_mode_on)
@@ -330,9 +330,9 @@ class TestHoneywellUS(unittest.TestCase):
 
     def test_unit_of_measurement(self):
         """Test the unit of measurement."""
-        self.assertEqual(TEMP_FAHRENHEIT, self.honeywell.unit_of_measurement)
+        self.assertEqual(TEMP_FAHRENHEIT, self.honeywell.temperature_unit)
         self.device.temperature_unit = 'C'
-        self.assertEqual(TEMP_CELSIUS, self.honeywell.unit_of_measurement)
+        self.assertEqual(TEMP_CELSIUS, self.honeywell.temperature_unit)
 
     def test_target_temp(self):
         """Test the target temperature."""