jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set lock state to unkown on BMW API error (#118559)

Browse Source 
* Revert to previous lock state on BMW API error

* Set lock state to unkown on error and force refresh from API

---------

Co-authored-by: Richard <rikroe@users.noreply.github.com>
This commit is contained in:
Richard Kroegel 2024-06-03 07:48:48 +02:00 committed by GitHub
parent c23ec96174
commit 7c5a6602b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/components/bmw_connected_drive/lock.py
View File

@ -65,11 +65,13 @@ class BMWLock(BMWBaseEntity, LockEntity):
try: try:
await self.vehicle.remote_services.trigger_remote_door_lock() await self.vehicle.remote_services.trigger_remote_door_lock()
except MyBMWAPIError as ex: except MyBMWAPIError as ex:
self._attr_is_locked = False # Set the state to unknown if the command fails
self._attr_is_locked = None
self.async_write_ha_state() self.async_write_ha_state()
raise HomeAssistantError(ex) from ex raise HomeAssistantError(ex) from ex
finally:
self.coordinator.async_update_listeners() # Always update the listeners to get the latest state
self.coordinator.async_update_listeners()
async def async_unlock(self, **kwargs: Any) -> None: async def async_unlock(self, **kwargs: Any) -> None:
"""Unlock the car.""" """Unlock the car."""
@ -83,11 +85,13 @@ class BMWLock(BMWBaseEntity, LockEntity):
try: try:
await self.vehicle.remote_services.trigger_remote_door_unlock() await self.vehicle.remote_services.trigger_remote_door_unlock()
except MyBMWAPIError as ex: except MyBMWAPIError as ex:
self._attr_is_locked = True # Set the state to unknown if the command fails
self._attr_is_locked = None
self.async_write_ha_state() self.async_write_ha_state()
raise HomeAssistantError(ex) from ex raise HomeAssistantError(ex) from ex
finally:
self.coordinator.async_update_listeners() # Always update the listeners to get the latest state
self.coordinator.async_update_listeners()
@callback @callback
def _handle_coordinator_update(self) -> None: def _handle_coordinator_update(self) -> None: