jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 22:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce discovery flow matching overhead (#107709)

Browse Source
This commit is contained in:
J. Nick Koston 2024-01-10 07:14:18 -10:00 committed by GitHub
parent 6a6c447c28
commit 7d18ad6fe7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/data_entry_flow.py
View File

@ -201,11 +201,13 @@ class FlowManager(abc.ABC):
If match_context is passed, only return flows with a context that is a If match_context is passed, only return flows with a context that is a
superset of match_context. superset of match_context.
""" """
return any( if not (flows := self._handler_progress_index.get(handler)):
flow return False
for flow in self._async_progress_by_handler(handler, match_context) match_items = match_context.items()
if flow.init_data == data for progress in flows:
) if match_items <= progress.context.items() and progress.init_data == data:
return True
return False
@callback @callback
def async_get(self, flow_id: str) -> FlowResult: def async_get(self, flow_id: str) -> FlowResult:
@ -265,11 +267,11 @@ class FlowManager(abc.ABC):
is a superset of match_context. is a superset of match_context.
""" """
if not match_context: if not match_context:
return list(self._handler_progress_index.get(handler, [])) return list(self._handler_progress_index.get(handler, ()))
match_context_items = match_context.items() match_context_items = match_context.items()
return [ return [
progress progress
for progress in self._handler_progress_index.get(handler, set()) for progress in self._handler_progress_index.get(handler, ())
if match_context_items <= progress.context.items() if match_context_items <= progress.context.items()
] ]

8
tests/test_data_entry_flow.py
View File

@ -546,6 +546,14 @@ async def test_async_has_matching_flow(
) -> None: ) -> None:
"""Test we can check for matching flows.""" """Test we can check for matching flows."""
manager.hass = hass manager.hass = hass
assert (
manager.async_has_matching_flow(
"test",
{"source": config_entries.SOURCE_HOMEKIT},
{"properties": {"id": "aa:bb:cc:dd:ee:ff"}},
)
is False
)
@manager.mock_reg_handler("test") @manager.mock_reg_handler("test")
class TestFlow(data_entry_flow.FlowHandler): class TestFlow(data_entry_flow.FlowHandler):