From 7e0560c7dccc7ccae79fd640c23638ce82328bd6 Mon Sep 17 00:00:00 2001 From: Hans Oischinger Date: Mon, 10 Feb 2020 21:23:02 +0100 Subject: [PATCH] Vicare water_heater set_temperature fix and bump PyVicare to 0.1.7 (#31672) * Fix ViCare water_heater set_temperature This fixes a obvious but undiscovered bug in the water heater component: Instead of the commanded value the prvious value was set on the API * Bump PyVicare to 0.1.7 --- homeassistant/components/vicare/manifest.json | 2 +- homeassistant/components/vicare/water_heater.py | 3 ++- requirements_all.txt | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/vicare/manifest.json b/homeassistant/components/vicare/manifest.json index cefc244e5b8..66fd15d3a90 100644 --- a/homeassistant/components/vicare/manifest.json +++ b/homeassistant/components/vicare/manifest.json @@ -4,5 +4,5 @@ "documentation": "https://www.home-assistant.io/integrations/vicare", "dependencies": [], "codeowners": ["@oischinger"], - "requirements": ["PyViCare==0.1.2"] + "requirements": ["PyViCare==0.1.7"] } diff --git a/homeassistant/components/vicare/water_heater.py b/homeassistant/components/vicare/water_heater.py index f31e4f65170..eea3d81faf6 100644 --- a/homeassistant/components/vicare/water_heater.py +++ b/homeassistant/components/vicare/water_heater.py @@ -122,7 +122,8 @@ class ViCareWater(WaterHeaterDevice): """Set new target temperatures.""" temp = kwargs.get(ATTR_TEMPERATURE) if temp is not None: - self._api.setDomesticHotWaterTemperature(self._target_temperature) + self._api.setDomesticHotWaterTemperature(temp) + self._target_temperature = temp @property def min_temp(self): diff --git a/requirements_all.txt b/requirements_all.txt index 0421344be0a..7079f858245 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -77,7 +77,7 @@ PySocks==1.7.1 PyTransportNSW==0.1.1 # homeassistant.components.vicare -PyViCare==0.1.2 +PyViCare==0.1.7 # homeassistant.components.xiaomi_aqara PyXiaomiGateway==0.12.4