jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Vicare water_heater set_temperature fix and bump PyVicare to 0.1.7 (#31672)

Browse Source 
* Fix ViCare water_heater set_temperature

This fixes a obvious but undiscovered bug in the water heater component:
Instead of the commanded value the prvious value was set on the API

* Bump PyVicare to 0.1.7
This commit is contained in:
Hans Oischinger 2020-02-10 21:23:02 +01:00 committed by GitHub
parent 5a7e0b84ff
commit 7e0560c7dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/vicare/manifest.json
View File

@ -4,5 +4,5 @@
"documentation": "https://www.home-assistant.io/integrations/vicare", "documentation": "https://www.home-assistant.io/integrations/vicare",
"dependencies": [], "dependencies": [],
"codeowners": ["@oischinger"], "codeowners": ["@oischinger"],
"requirements": ["PyViCare==0.1.2"] "requirements": ["PyViCare==0.1.7"]
} }

3
homeassistant/components/vicare/water_heater.py
View File

@ -122,7 +122,8 @@ class ViCareWater(WaterHeaterDevice):
"""Set new target temperatures.""" """Set new target temperatures."""
temp = kwargs.get(ATTR_TEMPERATURE) temp = kwargs.get(ATTR_TEMPERATURE)
if temp is not None: if temp is not None:
self._api.setDomesticHotWaterTemperature(self._target_temperature) self._api.setDomesticHotWaterTemperature(temp)
self._target_temperature = temp
@property @property
def min_temp(self): def min_temp(self):

2
requirements_all.txt
View File

@ -77,7 +77,7 @@ PySocks==1.7.1
PyTransportNSW==0.1.1 PyTransportNSW==0.1.1
# homeassistant.components.vicare # homeassistant.components.vicare
PyViCare==0.1.2 PyViCare==0.1.7
# homeassistant.components.xiaomi_aqara # homeassistant.components.xiaomi_aqara
PyXiaomiGateway==0.12.4 PyXiaomiGateway==0.12.4