jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-14 16:57:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing device class in netatmo binary sensors (#31693)

Browse Source 
* Bring back device class

* Add door tag sensors types

* Actually discover individual tags per camera
This commit is contained in:
cgtobi 2020-02-12 03:02:13 +01:00 committed by Paulus Schoutsen
parent 295963f8e8
commit 7edf0460cc
1 changed files with 33 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
homeassistant/components/netatmo/binary_sensor.py
View File

@ -24,7 +24,10 @@ PRESENCE_SENSOR_TYPES = {
} }
TAG_SENSOR_TYPES = {"Tag Vibration": "vibration", "Tag Open": "opening"} TAG_SENSOR_TYPES = {"Tag Vibration": "vibration", "Tag Open": "opening"}
SENSOR_TYPES = {"NACamera": WELCOME_SENSOR_TYPES, "NOC": PRESENCE_SENSOR_TYPES} SENSOR_TYPES = {
"NACamera": WELCOME_SENSOR_TYPES,
"NOC": PRESENCE_SENSOR_TYPES,
}
CONF_HOME = "home" CONF_HOME = "home"
CONF_CAMERAS = "cameras" CONF_CAMERAS = "cameras"
@ -61,12 +64,28 @@ async def async_setup_entry(hass, entry, async_add_entities):
sensor_types.update(SENSOR_TYPES[camera["type"]]) sensor_types.update(SENSOR_TYPES[camera["type"]])
# Tags are only supported with Netatmo Welcome indoor cameras # Tags are only supported with Netatmo Welcome indoor cameras
if camera["type"] == "NACamera" and data.get_modules(camera["id"]): modules = data.get_modules(camera["id"])
sensor_types.update(TAG_SENSOR_TYPES) if camera["type"] == "NACamera" and modules:
for module in modules:
for sensor_type in TAG_SENSOR_TYPES:
_LOGGER.debug(
"Adding camera tag %s (%s)",
module["name"],
module["id"],
)
entities.append(
NetatmoBinarySensor(
data,
camera["id"],
home_id,
sensor_type,
module["id"],
)
)
for sensor_name in sensor_types: for sensor_type in sensor_types:
entities.append( entities.append(
NetatmoBinarySensor(data, camera["id"], home_id, sensor_name) NetatmoBinarySensor(data, camera["id"], home_id, sensor_type)
) )
except pyatmo.NoDevice: except pyatmo.NoDevice:
_LOGGER.debug("No camera entities to add") _LOGGER.debug("No camera entities to add")
@ -115,6 +134,15 @@ class NetatmoBinarySensor(BinarySensorDevice):
"""Return the unique ID for this sensor.""" """Return the unique ID for this sensor."""
return self._unique_id return self._unique_id
@property
def device_class(self):
"""Return the class of this sensor."""
if self._camera_type == "NACamera":
return WELCOME_SENSOR_TYPES.get(self._sensor_type)
if self._camera_type == "NOC":
return PRESENCE_SENSOR_TYPES.get(self._sensor_type)
return TAG_SENSOR_TYPES.get(self._sensor_type)
@property @property
def device_info(self): def device_info(self):
"""Return the device info for the sensor.""" """Return the device info for the sensor."""