From 7f4d178781fd77fddbfb8f13d3e7bb901fd19804 Mon Sep 17 00:00:00 2001
From: TimL <tl@smlight.tech>
Date: Thu, 10 Apr 2025 03:04:19 +1000
Subject: [PATCH] Make exceptions translatable for SMLIGHT (#142587)

* Exceptions translations

* check off quality scale

* translate another exception
---
 homeassistant/components/smlight/coordinator.py     |  6 +++++-
 homeassistant/components/smlight/quality_scale.yaml |  2 +-
 homeassistant/components/smlight/strings.json       |  8 ++++++++
 homeassistant/components/smlight/update.py          | 10 ++++++++--
 4 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/homeassistant/components/smlight/coordinator.py b/homeassistant/components/smlight/coordinator.py
index 5a118e7de15..8a8dcd74b8f 100644
--- a/homeassistant/components/smlight/coordinator.py
+++ b/homeassistant/components/smlight/coordinator.py
@@ -111,7 +111,11 @@ class SmBaseDataUpdateCoordinator[_DataT](DataUpdateCoordinator[_DataT]):
             raise ConfigEntryAuthFailed from err
 
         except SmlightConnectionError as err:
-            raise UpdateFailed(err) from err
+            raise UpdateFailed(
+                translation_domain=DOMAIN,
+                translation_key="cannot_connect_device",
+                translation_placeholders={"error": str(err)},
+            ) from err
 
     @abstractmethod
     async def _internal_update_data(self) -> _DataT:
diff --git a/homeassistant/components/smlight/quality_scale.yaml b/homeassistant/components/smlight/quality_scale.yaml
index 0e1d4616d2a..5c6d7364704 100644
--- a/homeassistant/components/smlight/quality_scale.yaml
+++ b/homeassistant/components/smlight/quality_scale.yaml
@@ -70,7 +70,7 @@ rules:
   entity-device-class: done
   entity-disabled-by-default: done
   entity-translations: done
-  exception-translations: todo
+  exception-translations: done
   icon-translations: done
   reconfiguration-flow: todo
   repair-issues: done
diff --git a/homeassistant/components/smlight/strings.json b/homeassistant/components/smlight/strings.json
index b74dab791de..4abc6349d1e 100644
--- a/homeassistant/components/smlight/strings.json
+++ b/homeassistant/components/smlight/strings.json
@@ -145,6 +145,14 @@
       }
     }
   },
+  "exceptions": {
+    "firmware_update_failed": {
+      "message": "Firmware update failed for {device_name}."
+    },
+    "cannot_connect_device": {
+      "message": "An error occurred while connecting to the SMLIGHT device: {error}."
+    }
+  },
   "issues": {
     "unsupported_firmware": {
       "title": "SLZB core firmware update required",
diff --git a/homeassistant/components/smlight/update.py b/homeassistant/components/smlight/update.py
index 48f9149645c..d7aed0ecb4d 100644
--- a/homeassistant/components/smlight/update.py
+++ b/homeassistant/components/smlight/update.py
@@ -22,7 +22,7 @@ from homeassistant.core import HomeAssistant, callback
 from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
 
-from .const import LOGGER
+from .const import DOMAIN, LOGGER
 from .coordinator import SmConfigEntry, SmFirmwareUpdateCoordinator, SmFwData
 from .entity import SmEntity
 
@@ -210,7 +210,13 @@ class SmUpdateEntity(SmEntity, UpdateEntity):
     def _update_failed(self, event: MessageEvent) -> None:
         self._update_done()
         self.coordinator.in_progress = False
-        raise HomeAssistantError(f"Update failed for {self.name}")
+        raise HomeAssistantError(
+            translation_domain=DOMAIN,
+            translation_key="firmware_update_failed",
+            translation_placeholders={
+                "device_name": str(self.name),
+            },
+        )
 
     async def async_install(
         self, version: str | None, backup: bool, **kwargs: Any