jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 21:27:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some bound attributes from enphase_envoy binary_sensor (#98477)

Browse Source 
Some of these were never used
This commit is contained in:
J. Nick Koston 2023-08-15 13:16:05 -05:00 committed by GitHub
parent 73f882bf36
commit 80d608bb5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
homeassistant/components/enphase_envoy/binary_sensor.py
View File

@ -186,13 +186,12 @@ class EnvoyEnpowerBinarySensorEntity(EnvoyBaseBinarySensorEntity):
super().__init__(coordinator, description) super().__init__(coordinator, description)
enpower = self.data.enpower enpower = self.data.enpower
assert enpower is not None assert enpower is not None
self._serial_number = enpower.serial_number self._attr_unique_id = f"{enpower.serial_number}_{description.key}"
self._attr_unique_id = f"{self._serial_number}_{description.key}"
self._attr_device_info = DeviceInfo( self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, self._serial_number)}, identifiers={(DOMAIN, enpower.serial_number)},
manufacturer="Enphase", manufacturer="Enphase",
model="Enpower", model="Enpower",
name=f"Enpower {self._serial_number}", name=f"Enpower {enpower.serial_number}",
sw_version=str(enpower.firmware_version), sw_version=str(enpower.firmware_version),
via_device=(DOMAIN, self.envoy_serial_num), via_device=(DOMAIN, self.envoy_serial_num),
) )
@ -218,15 +217,13 @@ class EnvoyRelayBinarySensorEntity(EnvoyBaseBinarySensorEntity):
super().__init__(coordinator, description) super().__init__(coordinator, description)
enpower = self.data.enpower enpower = self.data.enpower
assert enpower is not None assert enpower is not None
self.relay_id = relay_id self._relay_id = relay_id
self.relay = self.data.dry_contact_settings[self.relay_id] self._attr_unique_id = f"{enpower.serial_number}_relay_{relay_id}"
self._serial_number = enpower.serial_number
self._attr_unique_id = f"{self._serial_number}_relay_{relay_id}"
self._attr_device_info = DeviceInfo( self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, relay_id)}, identifiers={(DOMAIN, relay_id)},
manufacturer="Enphase", manufacturer="Enphase",
model="Dry contact relay", model="Dry contact relay",
name=self.relay.load_name, name=self.data.dry_contact_settings[relay_id].load_name,
sw_version=str(enpower.firmware_version), sw_version=str(enpower.firmware_version),
via_device=(DOMAIN, enpower.serial_number), via_device=(DOMAIN, enpower.serial_number),
) )
@ -234,5 +231,5 @@ class EnvoyRelayBinarySensorEntity(EnvoyBaseBinarySensorEntity):
@property @property
def is_on(self) -> bool: def is_on(self) -> bool:
"""Return the state of the Enpower binary_sensor.""" """Return the state of the Enpower binary_sensor."""
relay = self.data.dry_contact_status[self.relay_id] relay = self.data.dry_contact_status[self._relay_id]
return relay.status == DryContactStatus.CLOSED return relay.status == DryContactStatus.CLOSED