jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-11 23:37:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Keep entity state management within entity (#63183)

Browse Source 
Simplify the entity state management for webrtc providers, incurring
extra state writes on startup.  Followup post-review comments for PR #62962
This commit is contained in:
Allen Porter 2022-01-01 11:22:48 -08:00 committed by GitHub
parent 0410c205ca
commit 81aff973ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
homeassistant/components/camera/__init__.py
View File

@ -316,13 +316,12 @@ def async_register_rtsp_to_web_rtc_provider(
async def _async_refresh_providers(hass: HomeAssistant) -> None: async def _async_refresh_providers(hass: HomeAssistant) -> None:
"""Check all cameras for any state changes for registered providers.""" """Check all cameras for any state changes for registered providers."""
async def _refresh(camera: Camera) -> None:
if await camera.async_refresh_providers():
camera.async_write_ha_state()
component: EntityComponent = hass.data[DOMAIN] component: EntityComponent = hass.data[DOMAIN]
await asyncio.gather( await asyncio.gather(
*(_refresh(cast(Camera, camera)) for camera in component.entities) *(
cast(Camera, camera).async_refresh_providers()
for camera in component.entities
)
) )
@ -681,10 +680,9 @@ class Camera(Entity):
async def async_internal_added_to_hass(self) -> None: async def async_internal_added_to_hass(self) -> None:
"""Run when entity about to be added to hass.""" """Run when entity about to be added to hass."""
await super().async_internal_added_to_hass() await super().async_internal_added_to_hass()
# Note: State is always updated by entity on return
await self.async_refresh_providers() await self.async_refresh_providers()
async def async_refresh_providers(self) -> bool: async def async_refresh_providers(self) -> None:
"""Determine if any of the registered providers are suitable for this entity. """Determine if any of the registered providers are suitable for this entity.
This affects state attributes, so it should be invoked any time the registered This affects state attributes, so it should be invoked any time the registered
@ -694,7 +692,8 @@ class Camera(Entity):
""" """
old_state = self._rtsp_to_webrtc old_state = self._rtsp_to_webrtc
self._rtsp_to_webrtc = await self._async_use_rtsp_to_webrtc() self._rtsp_to_webrtc = await self._async_use_rtsp_to_webrtc()
return old_state != self._rtsp_to_webrtc if old_state != self._rtsp_to_webrtc:
self.async_write_ha_state()
async def _async_use_rtsp_to_webrtc(self) -> bool: async def _async_use_rtsp_to_webrtc(self) -> bool:
"""Determine if a WebRTC provider can be used for the camera.""" """Determine if a WebRTC provider can be used for the camera."""