From 826587abb265e4a16142893587130ef0203671d5 Mon Sep 17 00:00:00 2001 From: "Mr. Bubbles" Date: Sun, 23 Jun 2024 13:16:00 +0200 Subject: [PATCH] Add `DeviceInfo` to pyLoad integration (#120232) * Add device info to pyLoad integration * Update homeassistant/components/pyload/sensor.py Co-authored-by: Joost Lekkerkerker * Update homeassistant/components/pyload/sensor.py Co-authored-by: Joost Lekkerkerker * remove name, add entry_type --------- Co-authored-by: Joost Lekkerkerker --- homeassistant/components/pyload/sensor.py | 11 ++++++++++- .../components/pyload/snapshots/test_sensor.ambr | 16 ++++++++-------- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/homeassistant/components/pyload/sensor.py b/homeassistant/components/pyload/sensor.py index 131fec68609..75f3227d542 100644 --- a/homeassistant/components/pyload/sensor.py +++ b/homeassistant/components/pyload/sensor.py @@ -36,6 +36,7 @@ from homeassistant.const import ( from homeassistant.core import DOMAIN as HOMEASSISTANT_DOMAIN, HomeAssistant from homeassistant.data_entry_flow import FlowResultType import homeassistant.helpers.config_validation as cv +from homeassistant.helpers.device_registry import DeviceEntryType, DeviceInfo from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.issue_registry import IssueSeverity, async_create_issue from homeassistant.helpers.typing import ConfigType, DiscoveryInfoType, StateType @@ -150,6 +151,8 @@ async def async_setup_entry( class PyLoadSensor(SensorEntity): """Representation of a pyLoad sensor.""" + _attr_has_entity_name = True + def __init__( self, api: PyLoadAPI, @@ -158,13 +161,19 @@ class PyLoadSensor(SensorEntity): entry_id: str, ) -> None: """Initialize a new pyLoad sensor.""" - self._attr_name = f"{client_name} {entity_description.name}" self.type = entity_description.key self.api = api self._attr_unique_id = f"{entry_id}_{entity_description.key}" self.entity_description = entity_description self._attr_available = False self.data: StatusServerResponse + self.device_info = DeviceInfo( + entry_type=DeviceEntryType.SERVICE, + manufacturer="PyLoad Team", + model="pyLoad", + configuration_url=api.api_url, + identifiers={(DOMAIN, entry_id)}, + ) async def async_update(self) -> None: """Update state of sensor.""" diff --git a/tests/components/pyload/snapshots/test_sensor.ambr b/tests/components/pyload/snapshots/test_sensor.ambr index 3aaa7f4679f..b772a2c39b1 100644 --- a/tests/components/pyload/snapshots/test_sensor.ambr +++ b/tests/components/pyload/snapshots/test_sensor.ambr @@ -12,7 +12,7 @@ 'domain': 'sensor', 'entity_category': None, 'entity_id': 'sensor.pyload_speed', - 'has_entity_name': False, + 'has_entity_name': True, 'hidden_by': None, 'icon': None, 'id': , @@ -29,7 +29,7 @@ }), 'original_device_class': , 'original_icon': None, - 'original_name': 'pyLoad Speed', + 'original_name': 'Speed', 'platform': 'pyload', 'previous_unique_id': None, 'supported_features': 0, @@ -66,7 +66,7 @@ 'domain': 'sensor', 'entity_category': None, 'entity_id': 'sensor.pyload_speed', - 'has_entity_name': False, + 'has_entity_name': True, 'hidden_by': None, 'icon': None, 'id': , @@ -83,7 +83,7 @@ }), 'original_device_class': , 'original_icon': None, - 'original_name': 'pyLoad Speed', + 'original_name': 'Speed', 'platform': 'pyload', 'previous_unique_id': None, 'supported_features': 0, @@ -120,7 +120,7 @@ 'domain': 'sensor', 'entity_category': None, 'entity_id': 'sensor.pyload_speed', - 'has_entity_name': False, + 'has_entity_name': True, 'hidden_by': None, 'icon': None, 'id': , @@ -137,7 +137,7 @@ }), 'original_device_class': , 'original_icon': None, - 'original_name': 'pyLoad Speed', + 'original_name': 'Speed', 'platform': 'pyload', 'previous_unique_id': None, 'supported_features': 0, @@ -351,7 +351,7 @@ 'domain': 'sensor', 'entity_category': None, 'entity_id': 'sensor.pyload_speed', - 'has_entity_name': False, + 'has_entity_name': True, 'hidden_by': None, 'icon': None, 'id': , @@ -368,7 +368,7 @@ }), 'original_device_class': , 'original_icon': None, - 'original_name': 'pyLoad Speed', + 'original_name': 'Speed', 'platform': 'pyload', 'previous_unique_id': None, 'supported_features': 0,