From 83fac6192d4287a565fe0d7995a4f669fa41dfe3 Mon Sep 17 00:00:00 2001
From: epenet <6771947+epenet@users.noreply.github.com>
Date: Thu, 4 Jul 2024 22:07:38 +0200
Subject: [PATCH] Use service_calls fixture in webostv tests (#120999)

---
 tests/components/webostv/conftest.py          |  9 ---------
 .../components/webostv/test_device_trigger.py | 12 +++++------
 tests/components/webostv/test_trigger.py      | 20 +++++++++----------
 3 files changed, 16 insertions(+), 25 deletions(-)

diff --git a/tests/components/webostv/conftest.py b/tests/components/webostv/conftest.py
index d25d1c7b031..a30ae933cca 100644
--- a/tests/components/webostv/conftest.py
+++ b/tests/components/webostv/conftest.py
@@ -6,12 +6,9 @@ from unittest.mock import AsyncMock, Mock, patch
 import pytest
 
 from homeassistant.components.webostv.const import LIVE_TV_APP_ID
-from homeassistant.core import HomeAssistant, ServiceCall
 
 from .const import CHANNEL_1, CHANNEL_2, CLIENT_KEY, FAKE_UUID, MOCK_APPS, MOCK_INPUTS
 
-from tests.common import async_mock_service
-
 
 @pytest.fixture
 def mock_setup_entry() -> Generator[AsyncMock]:
@@ -22,12 +19,6 @@ def mock_setup_entry() -> Generator[AsyncMock]:
         yield mock_setup_entry
 
 
-@pytest.fixture
-def calls(hass: HomeAssistant) -> list[ServiceCall]:
-    """Track calls to a mock service."""
-    return async_mock_service(hass, "test", "automation")
-
-
 @pytest.fixture(name="client")
 def client_fixture():
     """Patch of client library for tests."""
diff --git a/tests/components/webostv/test_device_trigger.py b/tests/components/webostv/test_device_trigger.py
index 29c75d4440b..41045969335 100644
--- a/tests/components/webostv/test_device_trigger.py
+++ b/tests/components/webostv/test_device_trigger.py
@@ -44,7 +44,7 @@ async def test_get_triggers(
 
 async def test_if_fires_on_turn_on_request(
     hass: HomeAssistant,
-    calls: list[ServiceCall],
+    service_calls: list[ServiceCall],
     device_registry: dr.DeviceRegistry,
     client,
 ) -> None:
@@ -97,11 +97,11 @@ async def test_if_fires_on_turn_on_request(
         blocking=True,
     )
 
-    assert len(calls) == 2
-    assert calls[0].data["some"] == device.id
-    assert calls[0].data["id"] == 0
-    assert calls[1].data["some"] == ENTITY_ID
-    assert calls[1].data["id"] == 0
+    assert len(service_calls) == 3
+    assert service_calls[1].data["some"] == device.id
+    assert service_calls[1].data["id"] == 0
+    assert service_calls[2].data["some"] == ENTITY_ID
+    assert service_calls[2].data["id"] == 0
 
 
 async def test_failure_scenarios(
diff --git a/tests/components/webostv/test_trigger.py b/tests/components/webostv/test_trigger.py
index 918666cf4bf..d7eeae28ea3 100644
--- a/tests/components/webostv/test_trigger.py
+++ b/tests/components/webostv/test_trigger.py
@@ -20,7 +20,7 @@ from tests.common import MockEntity, MockEntityPlatform
 
 async def test_webostv_turn_on_trigger_device_id(
     hass: HomeAssistant,
-    calls: list[ServiceCall],
+    service_calls: list[ServiceCall],
     device_registry: dr.DeviceRegistry,
     client,
 ) -> None:
@@ -58,14 +58,14 @@ async def test_webostv_turn_on_trigger_device_id(
         blocking=True,
     )
 
-    assert len(calls) == 1
-    assert calls[0].data["some"] == device.id
-    assert calls[0].data["id"] == 0
+    assert len(service_calls) == 2
+    assert service_calls[1].data["some"] == device.id
+    assert service_calls[1].data["id"] == 0
 
     with patch("homeassistant.config.load_yaml_dict", return_value={}):
         await hass.services.async_call(automation.DOMAIN, SERVICE_RELOAD, blocking=True)
 
-    calls.clear()
+    service_calls.clear()
 
     with pytest.raises(HomeAssistantError):
         await hass.services.async_call(
@@ -75,11 +75,11 @@ async def test_webostv_turn_on_trigger_device_id(
             blocking=True,
         )
 
-    assert len(calls) == 0
+    assert len(service_calls) == 1
 
 
 async def test_webostv_turn_on_trigger_entity_id(
-    hass: HomeAssistant, calls: list[ServiceCall], client
+    hass: HomeAssistant, service_calls: list[ServiceCall], client
 ) -> None:
     """Test for turn_on triggers by entity_id firing."""
     await setup_webostv(hass)
@@ -113,9 +113,9 @@ async def test_webostv_turn_on_trigger_entity_id(
         blocking=True,
     )
 
-    assert len(calls) == 1
-    assert calls[0].data["some"] == ENTITY_ID
-    assert calls[0].data["id"] == 0
+    assert len(service_calls) == 2
+    assert service_calls[1].data["some"] == ENTITY_ID
+    assert service_calls[1].data["id"] == 0
 
 
 async def test_wrong_trigger_platform_type(