Rewrite configurator tests to pytest (#41731)

tests/components/configurator/test_init.py

@@ -1,33 +1,18 @@
 """The tests for the Configurator component."""
-# pylint: disable=protected-access
-import unittest
 
 import homeassistant.components.configurator as configurator
 from homeassistant.const import ATTR_FRIENDLY_NAME, EVENT_TIME_CHANGED
 
-from tests.common import get_test_home_assistant
 
-
+async def test_request_least_info(hass):
-class TestConfigurator(unittest.TestCase):
-    """Test the Configurator component."""
-
-    # pylint: disable=invalid-name
-    def setUp(self):
-        """Set up things to be run when tests are started."""
-        self.hass = get_test_home_assistant()
-        self.addCleanup(self.hass.stop)
-
-    def test_request_least_info(self):
     """Test request config with least amount of data."""
-        request_id = configurator.request_config(
+    request_id = configurator.async_request_config(hass, "Test Request", lambda _: None)
-            self.hass, "Test Request", lambda _: None
-        )
 
     assert 1 == len(
-            self.hass.services.services.get(configurator.DOMAIN, [])
+        hass.services.async_services().get(configurator.DOMAIN, [])
     ), "No new service registered"
 
-        states = self.hass.states.all()
+    states = hass.states.async_all()
 
     assert 1 == len(states), "Expected a new state registered"
 
@@ -36,7 +21,8 @@ class TestConfigurator(unittest.TestCase):
     assert configurator.STATE_CONFIGURE == state.state
     assert request_id == state.attributes.get(configurator.ATTR_CONFIGURE_ID)
 
-    def test_request_all_info(self):
+
+async def test_request_all_info(hass):
     """Test request config with all possible info."""
     exp_attr = {
         ATTR_FRIENDLY_NAME: "Test Request",
@@ -48,8 +34,8 @@ class TestConfigurator(unittest.TestCase):
         configurator.ATTR_SUBMIT_CAPTION: "config submit caption",
         configurator.ATTR_FIELDS: [],
         configurator.ATTR_ENTITY_PICTURE: "config entity picture",
-            configurator.ATTR_CONFIGURE_ID: configurator.request_config(
+        configurator.ATTR_CONFIGURE_ID: configurator.async_request_config(
-                self.hass,
+            hass,
             name="Test Request",
             callback=lambda _: None,
             description="config description",
@@ -62,56 +48,59 @@ class TestConfigurator(unittest.TestCase):
         ),
     }
 
-        states = self.hass.states.all()
+    states = hass.states.async_all()
     assert 1 == len(states)
     state = states[0]
 
     assert configurator.STATE_CONFIGURE == state.state
     assert exp_attr == state.attributes
 
-    def test_callback_called_on_configure(self):
+
+async def test_callback_called_on_configure(hass):
     """Test if our callback gets called when configure service called."""
     calls = []
-        request_id = configurator.request_config(
+    request_id = configurator.async_request_config(
-            self.hass, "Test Request", lambda _: calls.append(1)
+        hass, "Test Request", lambda _: calls.append(1)
     )
 
-        self.hass.services.call(
+    await hass.services.async_call(
         configurator.DOMAIN,
         configurator.SERVICE_CONFIGURE,
         {configurator.ATTR_CONFIGURE_ID: request_id},
     )
 
-        self.hass.block_till_done()
+    await hass.async_block_till_done()
     assert 1 == len(calls), "Callback not called"
 
-    def test_state_change_on_notify_errors(self):
-        """Test state change on notify errors."""
-        request_id = configurator.request_config(
-            self.hass, "Test Request", lambda _: None
-        )
-        error = "Oh no bad bad bad"
-        configurator.notify_errors(self.hass, request_id, error)
 
-        state = self.hass.states.all()[0]
+async def test_state_change_on_notify_errors(hass):
+    """Test state change on notify errors."""
+    request_id = configurator.async_request_config(hass, "Test Request", lambda _: None)
+    error = "Oh no bad bad bad"
+    configurator.async_notify_errors(hass, request_id, error)
+
+    states = hass.states.async_all()
+    assert 1 == len(states)
+    state = states[0]
     assert error == state.attributes.get(configurator.ATTR_ERRORS)
 
-    def test_notify_errors_fail_silently_on_bad_request_id(self):
+
+async def test_notify_errors_fail_silently_on_bad_request_id(hass):
     """Test if notify errors fails silently with a bad request id."""
-        configurator.notify_errors(self.hass, 2015, "Try this error")
+    configurator.async_notify_errors(hass, 2015, "Try this error")
 
-    def test_request_done_works(self):
+
+async def test_request_done_works(hass):
     """Test if calling request done works."""
-        request_id = configurator.request_config(
+    request_id = configurator.async_request_config(hass, "Test Request", lambda _: None)
-            self.hass, "Test Request", lambda _: None
+    configurator.async_request_done(hass, request_id)
-        )
+    assert 1 == len(hass.states.async_all())
-        configurator.request_done(self.hass, request_id)
-        assert 1 == len(self.hass.states.all())
 
-        self.hass.bus.fire(EVENT_TIME_CHANGED)
+    hass.bus.async_fire(EVENT_TIME_CHANGED)
-        self.hass.block_till_done()
+    await hass.async_block_till_done()
-        assert 0 == len(self.hass.states.all())
+    assert 0 == len(hass.states.async_all())
 
-    def test_request_done_fail_silently_on_bad_request_id(self):
+
+async def test_request_done_fail_silently_on_bad_request_id(hass):
     """Test that request_done fails silently with a bad request id."""
-        configurator.request_done(self.hass, 2016)
+    configurator.async_request_done(hass, 2016)