jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 09:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer mac for onvif device identifier (#38864)

Browse Source
This commit is contained in:
Andrey Kupreychik 2020-08-21 01:39:04 +07:00 committed by GitHub
parent 96a1c80626
commit 8500e3c5a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/onvif/base.py
View File

@ -28,17 +28,17 @@ class ONVIFBaseEntity(Entity):
"model": self.device.info.model, "model": self.device.info.model,
"name": self.device.name, "name": self.device.name,
"sw_version": self.device.info.fw_version, "sw_version": self.device.info.fw_version,
"identifiers": {
# MAC address is not always available, and given the number
# of non-conformant ONVIF devices we have historically supported,
# we can not guarantee serial number either. Due to this, we have
# adopted an either/or approach in the config entry setup, and can
# guarantee that one or the other will be populated.
# See: https://github.com/home-assistant/core/issues/35883
(DOMAIN, self.device.info.mac or self.device.info.serial_number)
},
} }
# MAC address is not always available, and given the number
# of non-conformant ONVIF devices we have historically supported,
# we can not guarantee serial number either. Due to this, we have
# adopted an either/or approach in the config entry setup, and can
# guarantee that one or the other will be populated.
# See: https://github.com/home-assistant/core/issues/35883
if self.device.info.serial_number:
device_info["identifiers"] = {(DOMAIN, self.device.info.serial_number)}
if self.device.info.mac: if self.device.info.mac:
device_info["connections"] = { device_info["connections"] = {
(CONNECTION_NETWORK_MAC, self.device.info.mac) (CONNECTION_NETWORK_MAC, self.device.info.mac)