Cosmetic adjustments

homeassistant/__init__.py

@@ -42,21 +42,31 @@ def start_home_assistant(eventbus):
             break
 
 def datetime_to_str(dattim):
-    """ Converts datetime to a string format. """
+    """ Converts datetime to a string format.
+
+    @rtype : str
+    """
     return dattim.strftime(DATE_STR_FORMAT)
 
 def str_to_datetime(dt_str):
-    """ Converts a string to a datetime object. """
+    """ Converts a string to a datetime object.
+
+    @rtype: datetime
+    """
     return datetime.strptime(dt_str, DATE_STR_FORMAT)
 
 def ensure_list(parameter):
-    """ Wraps parameter in a list if it is not one and returns it. """
+    """ Wraps parameter in a list if it is not one and returns it.
+
+    @rtype : list
+    """
     return parameter if isinstance(parameter, list) else [parameter]
 
 def matcher(subject, pattern):
     """ Returns True if subject matches the pattern.
 
     Pattern is either a list of allowed subjects or a '*'.
+    @rtype : bool
     """
     return '*' in pattern or subject in pattern
 

homeassistant/actors.py

@@ -97,11 +97,11 @@ class LightTrigger(object):
 
         start_point = self._time_for_light_before_sun_set()
 
-        def turn_on(light_id):
+        def turn_on(light):
             """ Lambda can keep track of function parameters but not local
             parameters. If we put the lambda directly in the below statement
             only the last light would be turned on.. """
-            return lambda now: self._turn_light_on_before_sunset(light_id)
+            return lambda now: self._turn_light_on_before_sunset(light)
 
         for index, light_id in enumerate(self.light_control.light_ids):
             ha.track_time_change(self.eventbus, turn_on(light_id),
@@ -146,7 +146,7 @@ class LightTrigger(object):
             # if someone would be home?
             # Check this by seeing if current time is later then the point
             # in time when we would start putting the lights on.
-            elif now > start_point and now < self._next_sun_setting():
+            elif start_point < now < self._next_sun_setting():
 
                 # Check for every light if it would be on if someone was home
                 # when the fading in started and turn it on if so

homeassistant/httpinterface.py

@@ -157,7 +157,7 @@ class RequestHandler(BaseHTTPRequestHandler):
                 '_handle_fire_event'),
 
               # Statis files
-              ('GET', re.compile(r'/static/(?P<file>[a-zA-Z\._\-0-9\/]+)'),
+              ('GET', re.compile(r'/static/(?P<file>[a-zA-Z\._\-0-9/]+)'),
                '_handle_get_static')
                 ]
 

homeassistant/observers.py

@@ -49,7 +49,7 @@ def track_sun(eventbus, statemachine, latitude, longitude):
     try:
         import ephem
     except ImportError:
-        logger.exception(("TrackSun:Error while importing dependency ephem."))
+        logger.exception("TrackSun:Error while importing dependency ephem.")
         return False
 
     sun = ephem.Sun() # pylint: disable=no-member