jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 09:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #618 from nkgilley/camera-fix

Browse Source 
add exception handling to generic camera requests function.
This commit is contained in:
Paulus Schoutsen 2015-11-15 10:02:20 -08:00
commit 869d6df65e
2 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/camera/__init__.py
View File

@ -87,7 +87,10 @@ def setup(hass, config):
if camera: if camera:
response = camera.camera_image() response = camera.camera_image()
handler.wfile.write(response) if response is not None:
handler.wfile.write(response)
else:
handler.send_response(HTTP_NOT_FOUND)
else: else:
handler.send_response(HTTP_NOT_FOUND) handler.send_response(HTTP_NOT_FOUND)
@ -129,7 +132,8 @@ def setup(hass, config):
while True: while True:
img_bytes = camera.camera_image() img_bytes = camera.camera_image()
if img_bytes is None:
continue
headers_str = '\r\n'.join(( headers_str = '\r\n'.join((
'Content-length: {}'.format(len(img_bytes)), 'Content-length: {}'.format(len(img_bytes)),
'Content-type: image/jpeg', 'Content-type: image/jpeg',

16
homeassistant/components/camera/generic.py
View File

@ -42,11 +42,19 @@ class GenericCamera(Camera):
def camera_image(self): def camera_image(self):
""" Return a still image reponse from the camera. """ """ Return a still image reponse from the camera. """
if self._username and self._password: if self._username and self._password:
response = requests.get( try:
self._still_image_url, response = requests.get(
auth=HTTPBasicAuth(self._username, self._password)) self._still_image_url,
auth=HTTPBasicAuth(self._username, self._password))
except requests.exceptions.RequestException as error:
_LOGGER.error('Error getting camera image: %s', error)
return None
else: else:
response = requests.get(self._still_image_url) try:
response = requests.get(self._still_image_url)
except requests.exceptions.RequestException as error:
_LOGGER.error('Error getting camera image: %s', error)
return None
return response.content return response.content