jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 15:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid race condition with UDP voice server starting in ESPHome (#111644)

Browse Source 
* Avoid race condition with UDP server starting

* Fix test
This commit is contained in:
Michael Hansen 2024-02-27 10:54:56 -06:00 committed by GitHub
parent 00d11ff68e
commit 890e651bdd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/esphome/voice_assistant.py
View File

@ -160,10 +160,10 @@ class VoiceAssistantUDPServer(asyncio.DatagramProtocol):
async def _iterate_packets(self) -> AsyncIterable[bytes]: async def _iterate_packets(self) -> AsyncIterable[bytes]:
"""Iterate over incoming packets.""" """Iterate over incoming packets."""
if not self.is_running:
raise RuntimeError("Not running")
while data := await self.queue.get(): while data := await self.queue.get():
if not self.is_running:
break
yield data yield data
def _event_callback(self, event: PipelineEvent) -> None: def _event_callback(self, event: PipelineEvent) -> None:

10
tests/components/esphome/test_voice_assistant.py
View File

@ -224,9 +224,13 @@ async def test_udp_server_queue(
voice_assistant_udp_server_v1.close() voice_assistant_udp_server_v1.close()
with pytest.raises(RuntimeError): # Stopping the UDP server should cause _iterate_packets to break out
async for data in voice_assistant_udp_server_v1._iterate_packets(): # immediately without yielding any data.
assert data == bytes(1024) has_data = False
async for _data in voice_assistant_udp_server_v1._iterate_packets():
has_data = True
assert not has_data, "Server was stopped"
async def test_error_calls_handle_finished( async def test_error_calls_handle_finished(