jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use _attr_** in openweathermap (#62179)

Browse Source 
Co-authored-by: epenet <epenet@users.noreply.github.com>
This commit is contained in:
epenet 2021-12-19 13:25:51 +01:00 committed by GitHub
parent 868a1c222c
commit 8bca984d61
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/openweathermap/sensor.py
View File

@ -9,7 +9,6 @@ from homeassistant.components.sensor import (
SensorEntityDescription,
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import ATTR_ATTRIBUTION
from homeassistant.core import HomeAssistant
from homeassistant.helpers.device_registry import DeviceEntryType
from homeassistant.helpers.entity import DeviceInfo
@ -71,7 +70,7 @@ class AbstractOpenWeatherMapSensor(SensorEntity):
"""Abstract class for an OpenWeatherMap sensor."""
_attr_should_poll = False
_attr_extra_state_attributes = {ATTR_ATTRIBUTION: ATTRIBUTION}
_attr_attribution = ATTRIBUTION
def __init__(
self,
@ -94,11 +93,6 @@ class AbstractOpenWeatherMapSensor(SensorEntity):
name=DEFAULT_NAME,
)
@property
def attribution(self) -> str:
"""Return the attribution."""
return ATTRIBUTION
@property
def available(self) -> bool:
"""Return True if entity is available."""

43
homeassistant/components/openweathermap/weather.py
View File

@ -47,6 +47,10 @@ async def async_setup_entry(
class OpenWeatherMapWeather(WeatherEntity):
"""Implementation of an OpenWeatherMap sensor."""
_attr_attribution = ATTRIBUTION
_attr_should_poll = False
_attr_temperature_unit = TEMP_CELSIUS
def __init__(
self,
name: str,
@ -54,39 +58,15 @@ class OpenWeatherMapWeather(WeatherEntity):
weather_coordinator: WeatherUpdateCoordinator,
) -> None:
"""Initialize the sensor."""
self._name = name
self._unique_id = unique_id
self._weather_coordinator = weather_coordinator
@property
def name(self) -> str:
"""Return the name of the sensor."""
return self._name
@property
def unique_id(self) -> str:
"""Return a unique_id for this entity."""
return self._unique_id
@property
def device_info(self) -> DeviceInfo:
"""Return the device info."""
return DeviceInfo(
self._attr_name = name
self._attr_unique_id = unique_id
self._attr_device_info = DeviceInfo(
entry_type=DeviceEntryType.SERVICE,
identifiers={(DOMAIN, self._unique_id)},
identifiers={(DOMAIN, unique_id)},
manufacturer=MANUFACTURER,
name=DEFAULT_NAME,
)
@property
def should_poll(self) -> bool:
"""Return the polling requirement of the entity."""
return False
@property
def attribution(self) -> str:
"""Return the attribution."""
return ATTRIBUTION
self._weather_coordinator = weather_coordinator
@property
def condition(self) -> str | None:
@ -98,11 +78,6 @@ class OpenWeatherMapWeather(WeatherEntity):
"""Return the temperature."""
return self._weather_coordinator.data[ATTR_API_TEMPERATURE]
@property
def temperature_unit(self) -> str:
"""Return the unit of measurement."""
return TEMP_CELSIUS
@property
def pressure(self) -> float | None:
"""Return the pressure."""