jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 14:47:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Limit cache size of EntityValues (#94983)

Browse Source
This commit is contained in:
J. Nick Koston 2023-06-21 22:23:35 +02:00 committed by GitHub
parent 90386bc036
commit 8d2daaa694
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
homeassistant/helpers/entity_values.py
View File

@ -3,14 +3,24 @@ from __future__ import annotations
from collections import OrderedDict from collections import OrderedDict
import fnmatch import fnmatch
from functools import lru_cache
import re import re
from typing import Any from typing import Any
from homeassistant.core import split_entity_id from homeassistant.core import split_entity_id
_MAX_EXPECTED_ENTITIES = 16384
class EntityValues: class EntityValues:
"""Class to store entity id based values.""" """Class to store entity id based values.
This class is expected to only be used infrequently
as it caches all entity ids up to _MAX_EXPECTED_ENTITIES.
The cache includes `self` so it is important to
only use this in places where usage of `EntityValues` is immortal.
"""
def __init__( def __init__(
self, self,
@ -19,7 +29,6 @@ class EntityValues:
glob: dict[str, dict[str, str]] | None = None, glob: dict[str, dict[str, str]] | None = None,
) -> None: ) -> None:
"""Initialize an EntityConfigDict.""" """Initialize an EntityConfigDict."""
self._cache: dict[str, dict[str, str]] = {}
self._exact = exact self._exact = exact
self._domain = domain self._domain = domain
@ -32,13 +41,11 @@ class EntityValues:
self._glob = compiled self._glob = compiled
@lru_cache(maxsize=_MAX_EXPECTED_ENTITIES)
def get(self, entity_id: str) -> dict[str, str]: def get(self, entity_id: str) -> dict[str, str]:
"""Get config for an entity id.""" """Get config for an entity id."""
if entity_id in self._cache:
return self._cache[entity_id]
domain, _ = split_entity_id(entity_id) domain, _ = split_entity_id(entity_id)
result = self._cache[entity_id] = {} result: dict[str, str] = {}
if self._domain is not None and domain in self._domain: if self._domain is not None and domain in self._domain:
result.update(self._domain[domain]) result.update(self._domain[domain])

7
tests/helpers/test_entity_values.py
View File

@ -10,9 +10,12 @@ def test_override_single_value() -> None:
"""Test values with exact match.""" """Test values with exact match."""
store = EV({ent: {"key": "value"}}) store = EV({ent: {"key": "value"}})
assert store.get(ent) == {"key": "value"} assert store.get(ent) == {"key": "value"}
assert len(store._cache) == 1 assert store.get.cache_info().currsize == 1
assert store.get.cache_info().misses == 1
assert store.get(ent) == {"key": "value"} assert store.get(ent) == {"key": "value"}
assert len(store._cache) == 1 assert store.get.cache_info().currsize == 1
assert store.get.cache_info().misses == 1
assert store.get.cache_info().hits == 1
def test_override_by_domain() -> None: def test_override_by_domain() -> None: