From 8d678209db1e69124fae9a69ad2edc959ac4135d Mon Sep 17 00:00:00 2001 From: Jan Bouwhuis Date: Tue, 24 Jan 2023 13:49:07 +0100 Subject: [PATCH] Add translation support for select selectors of derivative config and option flow (#86190) * Add translation support for derivative config flow * Revert translation support for SI units * Undo test changes * Remove redundant labels --- homeassistant/components/derivative/config_flow.py | 12 +++++++----- homeassistant/components/derivative/strings.json | 10 ++++++++++ .../components/derivative/translations/en.json | 12 +++++++++++- 3 files changed, 28 insertions(+), 6 deletions(-) diff --git a/homeassistant/components/derivative/config_flow.py b/homeassistant/components/derivative/config_flow.py index f0ce6803719..e7c7a44117a 100644 --- a/homeassistant/components/derivative/config_flow.py +++ b/homeassistant/components/derivative/config_flow.py @@ -34,10 +34,10 @@ UNIT_PREFIXES = [ selector.SelectOptionDict(value="P", label="P (peta)"), ] TIME_UNITS = [ - selector.SelectOptionDict(value=UnitOfTime.SECONDS, label="Seconds"), - selector.SelectOptionDict(value=UnitOfTime.MINUTES, label="Minutes"), - selector.SelectOptionDict(value=UnitOfTime.HOURS, label="Hours"), - selector.SelectOptionDict(value=UnitOfTime.DAYS, label="Days"), + UnitOfTime.SECONDS, + UnitOfTime.MINUTES, + UnitOfTime.HOURS, + UnitOfTime.DAYS, ] OPTIONS_SCHEMA = vol.Schema( @@ -55,7 +55,9 @@ OPTIONS_SCHEMA = vol.Schema( selector.SelectSelectorConfig(options=UNIT_PREFIXES), ), vol.Required(CONF_UNIT_TIME, default=UnitOfTime.HOURS): selector.SelectSelector( - selector.SelectSelectorConfig(options=TIME_UNITS), + selector.SelectSelectorConfig( + options=TIME_UNITS, translation_key="time_unit" + ), ), } ) diff --git a/homeassistant/components/derivative/strings.json b/homeassistant/components/derivative/strings.json index 0a58b28a1c6..35f1679a31b 100644 --- a/homeassistant/components/derivative/strings.json +++ b/homeassistant/components/derivative/strings.json @@ -39,5 +39,15 @@ } } } + }, + "selector": { + "time_unit": { + "options": { + "s": "Seconds", + "min": "Minutes", + "h": "Hours", + "d": "Days" + } + } } } diff --git a/homeassistant/components/derivative/translations/en.json b/homeassistant/components/derivative/translations/en.json index b91318b5237..5e10c42b69d 100644 --- a/homeassistant/components/derivative/translations/en.json +++ b/homeassistant/components/derivative/translations/en.json @@ -39,5 +39,15 @@ } } }, - "title": "Derivative sensor" + "title": "Derivative sensor", + "selector": { + "time_unit": { + "options": { + "s": "Seconds", + "min": "Minutes", + "h": "Hours", + "d": "Days" + } + } + } } \ No newline at end of file