jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-24 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow max to be equal with min for mqtt number config validation (#142522)

Browse Source
This commit is contained in:
Jan Bouwhuis 2025-04-08 12:00:05 +02:00 committed by Franck Nijhof
parent d9f91598a5
commit 8dc21ef619
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
2 changed files with 44 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/mqtt/number.py
View File

@ -70,8 +70,8 @@ MQTT_NUMBER_ATTRIBUTES_BLOCKED = frozenset(
def validate_config(config: ConfigType) -> ConfigType:
"""Validate that the configuration is valid, throws if it isn't."""
if config[CONF_MIN] >= config[CONF_MAX]:
raise vol.Invalid(f"'{CONF_MAX}' must be > '{CONF_MIN}'")
if config[CONF_MIN] > config[CONF_MAX]:
raise vol.Invalid(f"{CONF_MAX} must be >= {CONF_MIN}")
return config

59
tests/components/mqtt/test_number.py
View File

@ -835,32 +835,57 @@ async def test_entity_debug_info_message(
@pytest.mark.parametrize(
"hass_config",
("hass_config", "min_number", "max_number", "step"),
[
{
mqtt.DOMAIN: {
number.DOMAIN: {
"state_topic": "test/state_number",
"command_topic": "test/cmd_number",
"name": "Test Number",
"min": 5,
"max": 110,
"step": 20,
(
{
mqtt.DOMAIN: {
number.DOMAIN: {
"state_topic": "test/state_number",
"command_topic": "test/cmd_number",
"name": "Test Number",
"min": 5,
"max": 110,
"step": 20,
}
}
}
}
},
5,
110,
20,
),
(
{
mqtt.DOMAIN: {
number.DOMAIN: {
"state_topic": "test/state_number",
"command_topic": "test/cmd_number",
"name": "Test Number",
"min": 100,
"max": 100,
}
}
},
100,
100,
1,
),
],
)
async def test_min_max_step_attributes(
hass: HomeAssistant, mqtt_mock_entry: MqttMockHAClientGenerator
hass: HomeAssistant,
mqtt_mock_entry: MqttMockHAClientGenerator,
min_number: float,
max_number: float,
step: float,
) -> None:
"""Test min/max/step attributes."""
await mqtt_mock_entry()
state = hass.states.get("number.test_number")
assert state.attributes.get(ATTR_MIN) == 5
assert state.attributes.get(ATTR_MAX) == 110
assert state.attributes.get(ATTR_STEP) == 20
assert state.attributes.get(ATTR_MIN) == min_number
assert state.attributes.get(ATTR_MAX) == max_number
assert state.attributes.get(ATTR_STEP) == step
@pytest.mark.parametrize(
@ -885,7 +910,7 @@ async def test_invalid_min_max_attributes(
) -> None:
"""Test invalid min/max attributes."""
assert await mqtt_mock_entry()
assert f"'{CONF_MAX}' must be > '{CONF_MIN}'" in caplog.text
assert f"{CONF_MAX} must be >= {CONF_MIN}" in caplog.text
@pytest.mark.parametrize(