jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure sonos ssdp callbacks use dataclass methods (#60782)

Browse Source
This commit is contained in:
J. Nick Koston 2021-12-02 07:53:08 -10:00 committed by GitHub
parent 0c18d710cc
commit 8e0ef52cc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
homeassistant/components/sonos/__init__.py
View File

@ -266,19 +266,27 @@ class SonosDiscoveryManager:
self.hass, f"{SONOS_SPEAKER_ACTIVITY}-{uid}", "discovery" self.hass, f"{SONOS_SPEAKER_ACTIVITY}-{uid}", "discovery"
) )
async def _async_ssdp_discovered_player(self, info, change): async def _async_ssdp_discovered_player(
self, info: ssdp.SsdpServiceInfo, change: ssdp.SsdpChange
) -> None:
if change == ssdp.SsdpChange.BYEBYE: if change == ssdp.SsdpChange.BYEBYE:
return return
uid = info.get(ssdp.ATTR_UPNP_UDN) uid = info.upnp[ssdp.ATTR_UPNP_UDN]
if not uid.startswith("uuid:RINCON_"): if not uid.startswith("uuid:RINCON_"):
return return
uid = uid[5:] uid = uid[5:]
discovered_ip = urlparse(info[ssdp.ATTR_SSDP_LOCATION]).hostname discovered_ip = urlparse(info.ssdp_location).hostname
boot_seqnum = info.get("X-RINCON-BOOTSEQ") boot_seqnum = info.ssdp_headers.get("X-RINCON-BOOTSEQ")
self.async_discovered_player( self.async_discovered_player(
"SSDP", info, discovered_ip, uid, boot_seqnum, info.get("modelName"), None "SSDP",
info,
discovered_ip,
uid,
boot_seqnum,
info.upnp.get(ssdp.ATTR_UPNP_MODEL_NAME),
None,
) )
@callback @callback

12
tests/components/sonos/conftest.py
View File

@ -94,10 +94,14 @@ def discover_fixture(soco):
async def do_callback(hass, callback, *args, **kwargs): async def do_callback(hass, callback, *args, **kwargs):
await callback( await callback(
{ ssdp.SsdpServiceInfo(
ssdp.ATTR_UPNP_UDN: f"uuid:{soco.uid}", ssdp_location=f"http://{soco.ip_address}/",
ssdp.ATTR_SSDP_LOCATION: f"http://{soco.ip_address}/", ssdp_st="urn:schemas-upnp-org:device:ZonePlayer:1",
}, ssdp_usn=f"uuid:{soco.uid}_MR::urn:schemas-upnp-org:service:GroupRenderingControl:1",
upnp={
ssdp.ATTR_UPNP_UDN: f"uuid:{soco.uid}",
},
),
ssdp.SsdpChange.ALIVE, ssdp.SsdpChange.ALIVE,
) )
return MagicMock() return MagicMock()