jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-20 11:47:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pylint and flake8

Browse Source
This commit is contained in:
Robbie Trencheny 2016-03-26 17:53:46 -07:00
parent 90f1b57ed8
commit 8fe1a9f008
1 changed files with 119 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
homeassistant/components/sensor/gtfs.py
View File

@ -9,7 +9,6 @@ import logging
import datetime import datetime
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.util import Throttle
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
@ -21,7 +20,11 @@ ICON = "mdi:train"
TIME_FORMAT = "%Y-%m-%d %H:%M:%S" TIME_FORMAT = "%Y-%m-%d %H:%M:%S"
# pylint: disable=too-many-locals
def get_next_departure(sched, start_station_id, end_station_id): def get_next_departure(sched, start_station_id, end_station_id):
"""Get the next departure for the given sched."""
origin_station = sched.stops_by_id(start_station_id)[0] origin_station = sched.stops_by_id(start_station_id)[0]
destination_station = sched.stops_by_id(end_station_id)[0] destination_station = sched.stops_by_id(end_station_id)[0]
@ -58,7 +61,8 @@ def get_next_departure(sched, start_station_id, end_station_id):
ON trip.trip_id = destination_stop_time.trip_id ON trip.trip_id = destination_stop_time.trip_id
INNER JOIN stops end_station INNER JOIN stops end_station
ON destination_stop_time.stop_id = end_station.stop_id ON destination_stop_time.stop_id = end_station.stop_id
WHERE calendar.{} = 1 AND time(origin_stop_time.departure_time) > time('{}') WHERE calendar.{} = 1
AND time(origin_stop_time.departure_time) > time('{}')
AND start_station.stop_id = '{}' AND end_station.stop_id = '{}' AND start_station.stop_id = '{}' AND end_station.stop_id = '{}'
ORDER BY origin_stop_time.departure_time LIMIT 1;"""\ ORDER BY origin_stop_time.departure_time LIMIT 1;"""\
.format(day_name, now_str, origin_station.id, destination_station.id) .format(day_name, now_str, origin_station.id, destination_station.id)
@ -80,25 +84,25 @@ def get_next_departure(sched, start_station_id, end_station_id):
route = sched.routes_by_id(item[1])[0] route = sched.routes_by_id(item[1])[0]
origin_stop_time_arrival_time = "{} {}".format(today, item[4]) origin_stoptime_arrival_time = "{} {}".format(today, item[4])
origin_stop_time_departure_time = "{} {}".format(today, item[5]) origin_stoptime_departure_time = "{} {}".format(today, item[5])
destination_stop_time_arrival_time = "{} {}".format(today, item[11]) dest_stoptime_arrival_time = "{} {}".format(today, item[11])
destination_stop_time_departure_time = "{} {}".format(today, item[12]) dest_stoptime_depart_time = "{} {}".format(today, item[12])
origin_stop_time_dict = { origin_stop_time_dict = {
"Arrival Time": origin_stop_time_arrival_time, "Arrival Time": origin_stoptime_arrival_time,
"Departure Time": origin_stop_time_departure_time, "Departure Time": origin_stoptime_departure_time,
"Drop Off Type": item[6], "Pickup Type": item[7], "Drop Off Type": item[6], "Pickup Type": item[7],
"Shape Dist Traveled": item[8], "Headsign": item[9], "Shape Dist Traveled": item[8], "Headsign": item[9],
"Sequence": item[10] "Sequence": item[10]
} }
destination_stop_time_dict = { destination_stop_time_dict = {
"Arrival Time": destination_stop_time_arrival_time, "Arrival Time": dest_stoptime_arrival_time,
"Departure Time": destination_stop_time_departure_time, "Departure Time": dest_stoptime_depart_time,
"Drop Off Type": item[13], "Pickup Type": item[14], "Drop Off Type": item[13], "Pickup Type": item[14],
"Shape Dist Traveled": item[15], "Headsign": item[16], "Shape Dist Traveled": item[15], "Headsign": item[16],
"Sequence": item[17] "Sequence": item[17]
@ -109,14 +113,17 @@ def get_next_departure(sched, start_station_id, end_station_id):
"trip": sched.trips_by_id(item[0])[0], "trip": sched.trips_by_id(item[0])[0],
"route": route, "route": route,
"agency": sched.agencies_by_id(route.agency_id)[0], "agency": sched.agencies_by_id(route.agency_id)[0],
"origin_station": origin_station, "departure_time": departure_time, "origin_station": origin_station,
"destination_station": destination_station, "arrival_time": arrival_time, "departure_time": departure_time,
"destination_station": destination_station,
"arrival_time": arrival_time,
"seconds_until_departure": seconds_until, "seconds_until_departure": seconds_until,
"minutes_until_departure": minutes_until, "minutes_until_departure": minutes_until,
"origin_stop_time": origin_stop_time_dict, "origin_stop_time": origin_stop_time_dict,
"destination_stop_time": destination_stop_time_dict "destination_stop_time": destination_stop_time_dict
} }
def setup_platform(hass, config, add_devices, discovery_info=None): def setup_platform(hass, config, add_devices, discovery_info=None):
"""Get the GTFS sensor.""" """Get the GTFS sensor."""
if config.get("origin") is None: if config.get("origin") is None:
@ -136,7 +143,9 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
config["origin"], config["destination"])) config["origin"], config["destination"]))
add_devices(dev) add_devices(dev)
# pylint: disable=too-few-public-methods # pylint: disable=too-many-instance-attributes,too-few-public-methods
class GTFSDepartureSensor(Entity): class GTFSDepartureSensor(Entity):
"""Implementation of an GTFS departures sensor.""" """Implementation of an GTFS departures sensor."""
@ -186,6 +195,7 @@ class GTFSDepartureSensor(Entity):
sqlite_file = "{}.sqlite".format(split_file_name[0]) sqlite_file = "{}.sqlite".format(split_file_name[0])
gtfs = pygtfs.Schedule(os.path.join(self._gtfs_folder, sqlite_file)) gtfs = pygtfs.Schedule(os.path.join(self._gtfs_folder, sqlite_file))
# pylint: disable=no-member
if len(gtfs.feeds) < 1: if len(gtfs.feeds) < 1:
pygtfs.append_feed(gtfs, os.path.join(self._gtfs_folder, pygtfs.append_feed(gtfs, os.path.join(self._gtfs_folder,
self._data_source)) self._data_source))
@ -211,26 +221,29 @@ class GTFSDepartureSensor(Entity):
self._attributes = {} self._attributes = {}
def dictForTable(resource): def dict_for_table(resource):
return dict((col, getattr(resource, col)) \ """Return a dict for the SQLAlchemy resource given."""
return dict((col, getattr(resource, col))
for col in resource.__table__.columns.keys()) for col in resource.__table__.columns.keys())
def appendKeys(resource, prefix=None): def append_keys(resource, prefix=None):
"""Properly format key val pairs to append to attributes"""
for key, val in resource.items(): for key, val in resource.items():
if val == "" or val is None or key == "feed_id": if val == "" or val is None or key == "feed_id":
continue continue
prettyKey = key.replace("_", " ") pretty_key = key.replace("_", " ")
prettyKey = prettyKey.title() pretty_key = pretty_key.title()
prettyKey = prettyKey.replace("Id", "ID") pretty_key = pretty_key.replace("Id", "ID")
prettyKey = prettyKey.replace("Url", "URL") pretty_key = pretty_key.replace("Url", "URL")
if prefix is not None and prettyKey.startswith(prefix) is False: if prefix is not None and \
prettyKey = "{} {}".format(prefix, prettyKey) pretty_key.startswith(prefix) is False:
self._attributes[prettyKey] = val pretty_key = "{} {}".format(prefix, pretty_key)
self._attributes[pretty_key] = val
appendKeys(dictForTable(agency), "Agency") append_keys(dict_for_table(agency), "Agency")
appendKeys(dictForTable(route), "Route") append_keys(dict_for_table(route), "Route")
appendKeys(dictForTable(trip), "Trip") append_keys(dict_for_table(trip), "Trip")
appendKeys(dictForTable(origin_station), "Origin Station") append_keys(dict_for_table(origin_station), "Origin Station")
appendKeys(dictForTable(destination_station), "Destination Station") append_keys(dict_for_table(destination_station), "Destination Station")
appendKeys(origin_stop_time, "Origin Stop") append_keys(origin_stop_time, "Origin Stop")
appendKeys(destination_stop_time, "Destination Stop") append_keys(destination_stop_time, "Destination Stop")