jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 22:27:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix implicit-return in twitter (#122931)

Browse Source
This commit is contained in:
epenet 2024-07-31 20:48:51 +02:00 committed by GitHub
parent c702ffa7dd
commit 9023d80d1b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
homeassistant/components/twitter/notify.py
View File

@ -129,10 +129,11 @@ class TwitterNotificationService(BaseNotificationService):
else: else:
_LOGGER.debug("Message posted: %s", resp.json()) _LOGGER.debug("Message posted: %s", resp.json())
def upload_media_then_callback(self, callback, media_path=None): def upload_media_then_callback(self, callback, media_path=None) -> None:
"""Upload media.""" """Upload media."""
if not media_path: if not media_path:
return callback() callback()
return
with open(media_path, "rb") as file: with open(media_path, "rb") as file:
total_bytes = os.path.getsize(media_path) total_bytes = os.path.getsize(media_path)
@ -141,7 +142,7 @@ class TwitterNotificationService(BaseNotificationService):
if 199 > resp.status_code < 300: if 199 > resp.status_code < 300:
self.log_error_resp(resp) self.log_error_resp(resp)
return None return
media_id = resp.json()["media_id"] media_id = resp.json()["media_id"]
media_id = self.upload_media_chunked(file, total_bytes, media_id) media_id = self.upload_media_chunked(file, total_bytes, media_id)
@ -149,10 +150,11 @@ class TwitterNotificationService(BaseNotificationService):
resp = self.upload_media_finalize(media_id) resp = self.upload_media_finalize(media_id)
if 199 > resp.status_code < 300: if 199 > resp.status_code < 300:
self.log_error_resp(resp) self.log_error_resp(resp)
return None return
if resp.json().get("processing_info") is None: if resp.json().get("processing_info") is None:
return callback(media_id) callback(media_id)
return
self.check_status_until_done(media_id, callback) self.check_status_until_done(media_id, callback)
@ -209,7 +211,7 @@ class TwitterNotificationService(BaseNotificationService):
"media/upload", {"command": "FINALIZE", "media_id": media_id} "media/upload", {"command": "FINALIZE", "media_id": media_id}
) )
def check_status_until_done(self, media_id, callback, *args): def check_status_until_done(self, media_id, callback, *args) -> None:
"""Upload media, STATUS phase.""" """Upload media, STATUS phase."""
resp = self.api.request( resp = self.api.request(
"media/upload", "media/upload",
@ -223,7 +225,8 @@ class TwitterNotificationService(BaseNotificationService):
_LOGGER.debug("media processing %s status: %s", media_id, processing_info) _LOGGER.debug("media processing %s status: %s", media_id, processing_info)
if processing_info["state"] in {"succeeded", "failed"}: if processing_info["state"] in {"succeeded", "failed"}:
return callback(media_id) callback(media_id)
return
check_after_secs = processing_info["check_after_secs"] check_after_secs = processing_info["check_after_secs"]
_LOGGER.debug( _LOGGER.debug(