From 911cf606782713f3e1ae064bafb9de5e586d62b1 Mon Sep 17 00:00:00 2001
From: Jan-Philipp Benecke <jan-philipp@bnck.me>
Date: Sun, 3 Mar 2024 18:10:22 +0100
Subject: [PATCH] Address late review for Ping (#112123)

* Address late review for Ping

* Fix import
---
 homeassistant/components/ping/binary_sensor.py | 2 +-
 homeassistant/components/ping/entity.py        | 4 +++-
 homeassistant/components/ping/sensor.py        | 4 +++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/homeassistant/components/ping/binary_sensor.py b/homeassistant/components/ping/binary_sensor.py
index eacf718b6a2..5c1435cc3b1 100644
--- a/homeassistant/components/ping/binary_sensor.py
+++ b/homeassistant/components/ping/binary_sensor.py
@@ -95,7 +95,7 @@ class PingBinarySensor(PingEntity, BinarySensorEntity):
         self, config_entry: ConfigEntry, coordinator: PingUpdateCoordinator
     ) -> None:
         """Initialize the Ping Binary sensor."""
-        super().__init__(coordinator, config_entry.entry_id)
+        super().__init__(config_entry, coordinator, config_entry.entry_id)
 
         # if this was imported just enable it when it was enabled before
         if CONF_IMPORTED_BY in config_entry.data:
diff --git a/homeassistant/components/ping/entity.py b/homeassistant/components/ping/entity.py
index 1332b82e9a8..8854634e898 100644
--- a/homeassistant/components/ping/entity.py
+++ b/homeassistant/components/ping/entity.py
@@ -1,4 +1,5 @@
 """Base entity for the Ping component."""
+from homeassistant.config_entries import ConfigEntry
 from homeassistant.core import DOMAIN
 from homeassistant.helpers.device_registry import DeviceInfo
 from homeassistant.helpers.update_coordinator import CoordinatorEntity
@@ -13,6 +14,7 @@ class PingEntity(CoordinatorEntity[PingUpdateCoordinator]):
 
     def __init__(
         self,
+        config_entry: ConfigEntry,
         coordinator: PingUpdateCoordinator,
         unique_id: str,
     ) -> None:
@@ -21,6 +23,6 @@ class PingEntity(CoordinatorEntity[PingUpdateCoordinator]):
 
         self._attr_unique_id = unique_id
         self._attr_device_info = DeviceInfo(
-            identifiers={(DOMAIN, self.coordinator.data.ip_address)},
+            identifiers={(DOMAIN, config_entry.entry_id)},
             manufacturer="Ping",
         )
diff --git a/homeassistant/components/ping/sensor.py b/homeassistant/components/ping/sensor.py
index 5010c93f314..f5e5de81aac 100644
--- a/homeassistant/components/ping/sensor.py
+++ b/homeassistant/components/ping/sensor.py
@@ -101,7 +101,9 @@ class PingSensor(PingEntity, SensorEntity):
         coordinator: PingUpdateCoordinator,
     ) -> None:
         """Initialize the sensor."""
-        super().__init__(coordinator, f"{config_entry.entry_id}-{description.key}")
+        super().__init__(
+            config_entry, coordinator, f"{config_entry.entry_id}-{description.key}"
+        )
 
         self.entity_description = description