diff --git a/homeassistant/components/remember_the_milk/__init__.py b/homeassistant/components/remember_the_milk/__init__.py index 8e8127bd29b..fb0a9d5106f 100644 --- a/homeassistant/components/remember_the_milk/__init__.py +++ b/homeassistant/components/remember_the_milk/__init__.py @@ -7,7 +7,7 @@ from rtmapi import Rtm, RtmRequestFailedException import voluptuous as vol from homeassistant.const import CONF_API_KEY, CONF_ID, CONF_NAME, CONF_TOKEN, STATE_OK -from homeassistant.core import HomeAssistant +from homeassistant.core import HomeAssistant, ServiceCall import homeassistant.helpers.config_validation as cv from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity_component import EntityComponent @@ -270,7 +270,7 @@ class RememberTheMilk(Entity): self._token_valid = True return self._token_valid - def create_task(self, call): + def create_task(self, call: ServiceCall) -> None: """Create a new task on Remember The Milk. You can use the smart syntax to define the attributes of a new task, @@ -278,7 +278,7 @@ class RememberTheMilk(Entity): due date to today. """ try: - task_name = call.data.get(CONF_NAME) + task_name = call.data[CONF_NAME] hass_id = call.data.get(CONF_ID) rtm_id = None if hass_id is not None: @@ -320,12 +320,10 @@ class RememberTheMilk(Entity): self._name, rtm_exception, ) - return False - return True - def complete_task(self, call): + def complete_task(self, call: ServiceCall) -> None: """Complete a task that was previously created by this component.""" - hass_id = call.data.get(CONF_ID) + hass_id = call.data[CONF_ID] rtm_id = self._rtm_config.get_rtm_id(self._name, hass_id) if rtm_id is None: _LOGGER.error( @@ -334,7 +332,7 @@ class RememberTheMilk(Entity): hass_id, self._name, ) - return False + return try: result = self._rtm_api.rtm.timelines.create() timeline = result.timeline.value @@ -354,7 +352,6 @@ class RememberTheMilk(Entity): self._name, rtm_exception, ) - return True @property def name(self):