Ensure Schlage config entry uniqueness (#131732)

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
This commit is contained in:
David Knowles 2024-12-02 09:18:17 -05:00 committed by GitHub
parent 2f644eb61c
commit 92520fe365
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 0 deletions

View File

@ -40,6 +40,7 @@ class SchlageConfigFlow(ConfigFlow, domain=DOMAIN):
return self._show_user_form(errors) return self._show_user_form(errors)
await self.async_set_unique_id(user_id) await self.async_set_unique_id(user_id)
self._abort_if_unique_id_configured()
return self.async_create_entry( return self.async_create_entry(
title=username, title=username,
data={ data={

View File

@ -12,6 +12,8 @@ from homeassistant.data_entry_flow import FlowResultType
from . import MockSchlageConfigEntry from . import MockSchlageConfigEntry
from tests.common import MockConfigEntry
pytestmark = pytest.mark.usefixtures("mock_setup_entry") pytestmark = pytest.mark.usefixtures("mock_setup_entry")
@ -54,6 +56,32 @@ async def test_form(
assert len(mock_setup_entry.mock_calls) == 1 assert len(mock_setup_entry.mock_calls) == 1
async def test_form_requires_unique_id(
hass: HomeAssistant,
mock_added_config_entry: MockConfigEntry,
mock_pyschlage_auth: Mock,
) -> None:
"""Test entries have unique ids."""
init_result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert init_result["type"] is FlowResultType.FORM
assert init_result["errors"] == {}
create_result = await hass.config_entries.flow.async_configure(
init_result["flow_id"],
{
"username": "test-username",
"password": "test-password",
},
)
await hass.async_block_till_done()
mock_pyschlage_auth.authenticate.assert_called_once_with()
assert create_result["type"] is FlowResultType.ABORT
assert create_result["reason"] == "already_configured"
async def test_form_invalid_auth( async def test_form_invalid_auth(
hass: HomeAssistant, mock_pyschlage_auth: Mock hass: HomeAssistant, mock_pyschlage_auth: Mock
) -> None: ) -> None: