From 929bcb92e2f0add2bd9f42cd1a243ffdea56ed6f Mon Sep 17 00:00:00 2001 From: Sid <27780930+autinerd@users.noreply.github.com> Date: Sun, 17 Mar 2024 15:59:49 +0100 Subject: [PATCH] Add Ruff LOG rules (#113677) * Add Ruff LOG rules * Address review comment * Update const.py --- homeassistant/components/logger/const.py | 2 +- homeassistant/components/system_log/__init__.py | 2 +- homeassistant/components/zha/core/gateway.py | 2 +- pyproject.toml | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/logger/const.py b/homeassistant/components/logger/const.py index 483d1e8a097..bc026d196b7 100644 --- a/homeassistant/components/logger/const.py +++ b/homeassistant/components/logger/const.py @@ -21,7 +21,7 @@ LOGSEVERITY = { LOGSEVERITY_FATAL: logging.FATAL, LOGSEVERITY_ERROR: logging.ERROR, LOGSEVERITY_WARNING: logging.WARNING, - LOGSEVERITY_WARN: logging.WARN, + LOGSEVERITY_WARN: logging.WARNING, LOGSEVERITY_INFO: logging.INFO, LOGSEVERITY_DEBUG: logging.DEBUG, LOGSEVERITY_NOTSET: logging.NOTSET, diff --git a/homeassistant/components/system_log/__init__.py b/homeassistant/components/system_log/__init__.py index 83a89a277cc..47351b196ba 100644 --- a/homeassistant/components/system_log/__init__.py +++ b/homeassistant/components/system_log/__init__.py @@ -294,7 +294,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool: handler = LogErrorHandler( hass, conf[CONF_MAX_ENTRIES], conf[CONF_FIRE_EVENT], paths_re ) - handler.setLevel(logging.WARN) + handler.setLevel(logging.WARNING) hass.data[DOMAIN] = handler diff --git a/homeassistant/components/zha/core/gateway.py b/homeassistant/components/zha/core/gateway.py index 55714bfef15..6706aef91f3 100644 --- a/homeassistant/components/zha/core/gateway.py +++ b/homeassistant/components/zha/core/gateway.py @@ -870,7 +870,7 @@ class LogRelayHandler(logging.Handler): def emit(self, record: LogRecord) -> None: """Relay log message via dispatcher.""" entry = LogEntry( - record, self.paths_re, figure_out_source=record.levelno >= logging.WARN + record, self.paths_re, figure_out_source=record.levelno >= logging.WARNING ) async_dispatcher_send( self.hass, diff --git a/pyproject.toml b/pyproject.toml index 5c6fbd2c1e7..56e5656a1d7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -601,6 +601,7 @@ select = [ "I", # isort "ISC", # flake8-implicit-str-concat "ICN001", # import concentions; {name} should be imported as {asname} + "LOG", # flake8-logging "N804", # First argument of a class method should be named cls "N805", # First argument of a method should be named self "N815", # Variable {name} in class scope should not be mixedCase