From 93db814b15a976ddc25236e4f16382968f2816ef Mon Sep 17 00:00:00 2001 From: bouni Date: Sat, 19 Oct 2019 00:01:03 +0200 Subject: [PATCH] Move imports in comfoconnect component (#27886) --- .../components/comfoconnect/__init__.py | 13 ++++++------- homeassistant/components/comfoconnect/fan.py | 17 ++++++++--------- homeassistant/components/comfoconnect/sensor.py | 17 +++++++++-------- 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/homeassistant/components/comfoconnect/__init__.py b/homeassistant/components/comfoconnect/__init__.py index 22e9d95bbd8..aef4bf1deeb 100644 --- a/homeassistant/components/comfoconnect/__init__.py +++ b/homeassistant/components/comfoconnect/__init__.py @@ -1,6 +1,12 @@ """Support to control a Zehnder ComfoAir Q350/450/600 ventilation unit.""" import logging +from pycomfoconnect import ( + SENSOR_TEMPERATURE_EXTRACT, + SENSOR_TEMPERATURE_OUTDOOR, + Bridge, + ComfoConnect, +) import voluptuous as vol from homeassistant.const import ( @@ -56,7 +62,6 @@ CONFIG_SCHEMA = vol.Schema( def setup(hass, config): """Set up the ComfoConnect bridge.""" - from pycomfoconnect import Bridge conf = config[DOMAIN] host = conf.get(CONF_HOST) @@ -97,7 +102,6 @@ class ComfoConnectBridge: def __init__(self, hass, bridge, name, token, friendly_name, pin): """Initialize the ComfoConnect bridge.""" - from pycomfoconnect import ComfoConnect self.data = {} self.name = name @@ -125,11 +129,6 @@ class ComfoConnectBridge: """Call function for sensor updates.""" _LOGGER.debug("Got value from bridge: %d = %d", var, value) - from pycomfoconnect import ( - SENSOR_TEMPERATURE_EXTRACT, - SENSOR_TEMPERATURE_OUTDOOR, - ) - if var in [SENSOR_TEMPERATURE_EXTRACT, SENSOR_TEMPERATURE_OUTDOOR]: self.data[var] = value / 10 else: diff --git a/homeassistant/components/comfoconnect/fan.py b/homeassistant/components/comfoconnect/fan.py index 6c90ab8cba1..bbb4b0176bf 100644 --- a/homeassistant/components/comfoconnect/fan.py +++ b/homeassistant/components/comfoconnect/fan.py @@ -1,6 +1,14 @@ """Platform to control a Zehnder ComfoAir Q350/450/600 ventilation unit.""" import logging +from pycomfoconnect import ( + CMD_FAN_MODE_AWAY, + CMD_FAN_MODE_HIGH, + CMD_FAN_MODE_LOW, + CMD_FAN_MODE_MEDIUM, + SENSOR_FAN_SPEED_MODE, +) + from homeassistant.components.fan import ( SPEED_HIGH, SPEED_LOW, @@ -30,7 +38,6 @@ class ComfoConnectFan(FanEntity): def __init__(self, hass, name, ccb: ComfoConnectBridge) -> None: """Initialize the ComfoConnect fan.""" - from pycomfoconnect import SENSOR_FAN_SPEED_MODE self._ccb = ccb self._name = name @@ -64,7 +71,6 @@ class ComfoConnectFan(FanEntity): @property def speed(self): """Return the current fan mode.""" - from pycomfoconnect import SENSOR_FAN_SPEED_MODE try: speed = self._ccb.data[SENSOR_FAN_SPEED_MODE] @@ -91,13 +97,6 @@ class ComfoConnectFan(FanEntity): """Set fan speed.""" _LOGGER.debug("Changing fan speed to %s.", speed) - from pycomfoconnect import ( - CMD_FAN_MODE_AWAY, - CMD_FAN_MODE_LOW, - CMD_FAN_MODE_MEDIUM, - CMD_FAN_MODE_HIGH, - ) - if speed == SPEED_OFF: self._ccb.comfoconnect.cmd_rmi_request(CMD_FAN_MODE_AWAY) elif speed == SPEED_LOW: diff --git a/homeassistant/components/comfoconnect/sensor.py b/homeassistant/components/comfoconnect/sensor.py index 4099804d413..06d0506e2cf 100644 --- a/homeassistant/components/comfoconnect/sensor.py +++ b/homeassistant/components/comfoconnect/sensor.py @@ -1,6 +1,15 @@ """Platform to control a Zehnder ComfoAir Q350/450/600 ventilation unit.""" import logging +from pycomfoconnect import ( + SENSOR_FAN_EXHAUST_FLOW, + SENSOR_FAN_SUPPLY_FLOW, + SENSOR_HUMIDITY_EXTRACT, + SENSOR_HUMIDITY_OUTDOOR, + SENSOR_TEMPERATURE_EXTRACT, + SENSOR_TEMPERATURE_OUTDOOR, +) + from homeassistant.const import CONF_RESOURCES, TEMP_CELSIUS from homeassistant.helpers.dispatcher import dispatcher_connect from homeassistant.helpers.entity import Entity @@ -24,14 +33,6 @@ SENSOR_TYPES = {} def setup_platform(hass, config, add_entities, discovery_info=None): """Set up the ComfoConnect fan platform.""" - from pycomfoconnect import ( - SENSOR_TEMPERATURE_EXTRACT, - SENSOR_HUMIDITY_EXTRACT, - SENSOR_TEMPERATURE_OUTDOOR, - SENSOR_HUMIDITY_OUTDOOR, - SENSOR_FAN_SUPPLY_FLOW, - SENSOR_FAN_EXHAUST_FLOW, - ) global SENSOR_TYPES SENSOR_TYPES = {