jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 20:57:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix nuheat unexpectedly switching to a permanent hold (#33316)

Browse Source 
When in run schedule mode, setting the temperature will switch
the device to a temporary hold.  If you set the temperature
again, we should stay in temporary hold mode and not switch
to permanent hold.

The underlying nuheat package contains a default to a
permanent hold if no setting was passed.  We now always
pass the setting.
This commit is contained in:
J. Nick Koston 2020-03-28 01:01:59 -05:00 committed by GitHub
parent 5ce31cb383
commit 95cefd1acc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
homeassistant/components/nuheat/climate.py
View File

@ -3,6 +3,7 @@ from datetime import timedelta
import logging
from nuheat.config import SCHEDULE_HOLD, SCHEDULE_RUN, SCHEDULE_TEMPORARY_HOLD
from nuheat.util import celsius_to_nuheat, fahrenheit_to_nuheat
from homeassistant.components.climate import ClimateDevice
from homeassistant.components.climate.const import (
@ -186,20 +187,26 @@ class NuHeatThermostat(ClimateDevice):
def _set_temperature(self, temperature):
if self._temperature_unit == "C":
self._thermostat.target_celsius = temperature
target_temp = celsius_to_nuheat(temperature)
else:
self._thermostat.target_fahrenheit = temperature
target_temp = fahrenheit_to_nuheat(temperature)
# If they set a temperature without changing the mode
# to heat, we behave like the device does locally
# and set a temp hold.
if self._thermostat.schedule_mode == SCHEDULE_RUN:
self._thermostat.schedule_mode = SCHEDULE_TEMPORARY_HOLD
target_schedule_mode = SCHEDULE_HOLD
if self._thermostat.schedule_mode in (SCHEDULE_RUN, SCHEDULE_TEMPORARY_HOLD):
target_schedule_mode = SCHEDULE_TEMPORARY_HOLD
_LOGGER.debug(
"Setting NuHeat thermostat temperature to %s %s",
"Setting NuHeat thermostat temperature to %s %s and schedule mode: %s",
temperature,
self.temperature_unit,
target_schedule_mode,
)
# If we do not send schedule_mode we always get
# SCHEDULE_HOLD
self._thermostat.set_target_temperature(target_temp, target_schedule_mode)
self._schedule_update()
def _schedule_update(self):