jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 22:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move available property to base entity in Sensibo (#134410)

Browse Source 
* Move available property to base entity in Sensibo

* Fix test
This commit is contained in:
G Johansson 2025-01-01 23:02:06 +01:00 committed by GitHub
parent 088b097a03
commit 97dc72a6e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/sensibo/climate.py
View File

@ -295,11 +295,6 @@ class SensiboClimate(SensiboDeviceBaseEntity, ClimateEntity):
"""Return the maximum temperature.""" """Return the maximum temperature."""
return self.device_data.temp_list[-1] return self.device_data.temp_list[-1]
@property
def available(self) -> bool:
"""Return True if entity is available."""
return self.device_data.available and super().available
async def async_set_temperature(self, **kwargs: Any) -> None: async def async_set_temperature(self, **kwargs: Any) -> None:
"""Set new target temperature.""" """Set new target temperature."""
if "targetTemperature" not in self.device_data.active_features: if "targetTemperature" not in self.device_data.active_features:

12
homeassistant/components/sensibo/entity.py
View File

@ -75,6 +75,11 @@ class SensiboBaseEntity(CoordinatorEntity[SensiboDataUpdateCoordinator]):
"""Return data for device.""" """Return data for device."""
return self.coordinator.data.parsed[self._device_id] return self.coordinator.data.parsed[self._device_id]
@property
def available(self) -> bool:
"""Return True if entity is available."""
return self.device_data.available and super().available
class SensiboDeviceBaseEntity(SensiboBaseEntity): class SensiboDeviceBaseEntity(SensiboBaseEntity):
"""Representation of a Sensibo Device.""" """Representation of a Sensibo Device."""
@ -125,8 +130,13 @@ class SensiboMotionBaseEntity(SensiboBaseEntity):
) )
@property @property
def sensor_data(self) -> MotionSensor | None: def sensor_data(self) -> MotionSensor:
"""Return data for Motion Sensor.""" """Return data for Motion Sensor."""
if TYPE_CHECKING: if TYPE_CHECKING:
assert self.device_data.motion_sensors assert self.device_data.motion_sensors
return self.device_data.motion_sensors[self._sensor_id] return self.device_data.motion_sensors[self._sensor_id]
@property
def available(self) -> bool:
"""Return True if entity is available."""
return bool(self.sensor_data.alive) and super().available

9
tests/components/sensibo/test_binary_sensor.py
View File

@ -10,7 +10,7 @@ import pytest
from syrupy.assertion import SnapshotAssertion from syrupy.assertion import SnapshotAssertion
from homeassistant.config_entries import ConfigEntry from homeassistant.config_entries import ConfigEntry
from homeassistant.const import Platform from homeassistant.const import STATE_OFF, STATE_ON, Platform
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.helpers import entity_registry as er from homeassistant.helpers import entity_registry as er
from homeassistant.util import dt as dt_util from homeassistant.util import dt as dt_util
@ -35,9 +35,6 @@ async def test_binary_sensor(
await snapshot_platform(hass, entity_registry, snapshot, load_int.entry_id) await snapshot_platform(hass, entity_registry, snapshot, load_int.entry_id)
monkeypatch.setattr(
get_data.parsed["ABC999111"].motion_sensors["AABBCC"], "alive", False
)
monkeypatch.setattr( monkeypatch.setattr(
get_data.parsed["ABC999111"].motion_sensors["AABBCC"], "motion", False get_data.parsed["ABC999111"].motion_sensors["AABBCC"], "motion", False
) )
@ -54,5 +51,5 @@ async def test_binary_sensor(
state1 = hass.states.get("binary_sensor.hallway_motion_sensor_connectivity") state1 = hass.states.get("binary_sensor.hallway_motion_sensor_connectivity")
state3 = hass.states.get("binary_sensor.hallway_motion_sensor_motion") state3 = hass.states.get("binary_sensor.hallway_motion_sensor_motion")
assert state1.state == "off" assert state1.state == STATE_ON
assert state3.state == "off" assert state3.state == STATE_OFF