jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-20 19:57:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove enphase_envoy config flow tests that make no sense (#133833)

Browse Source
This commit is contained in:
Arie Catsman 2025-01-08 20:09:06 +01:00 committed by GitHub
parent c9c553047c
commit 988a0639f4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 118 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/enphase_envoy/quality_scale.yaml
View File

@ -8,11 +8,7 @@ rules:
comment: fixed 1 minute cycle based on Enphase Envoy device characteristics comment: fixed 1 minute cycle based on Enphase Envoy device characteristics
brands: done brands: done
common-modules: done common-modules: done
config-flow-test-coverage: config-flow-test-coverage: done
status: todo
comment: |
- test_zero_conf_malformed_serial_property - with pytest.raises(KeyError) as ex::
I don't believe this should be able to raise a KeyError Shouldn't we abort the flow?
config-flow: config-flow:
status: todo status: todo
comment: | comment: |

113
tests/components/enphase_envoy/test_config_flow.py
View File

@ -434,119 +434,6 @@ async def test_zero_conf_second_envoy_while_form(
assert result4["type"] is FlowResultType.ABORT assert result4["type"] is FlowResultType.ABORT
async def test_zero_conf_malformed_serial_property(
hass: HomeAssistant,
config_entry: MockConfigEntry,
mock_setup_entry: AsyncMock,
mock_envoy: AsyncMock,
) -> None:
"""Test malformed zeroconf properties."""
await setup_integration(hass, config_entry)
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_USER}
)
assert result["type"] is FlowResultType.FORM
with pytest.raises(KeyError) as ex:
await hass.config_entries.flow.async_init(
DOMAIN,
context={"source": SOURCE_ZEROCONF},
data=zeroconf.ZeroconfServiceInfo(
ip_address=ip_address("1.1.1.1"),
ip_addresses=[ip_address("1.1.1.1")],
hostname="mock_hostname",
name="mock_name",
port=None,
properties={"serilnum": "1234", "protovers": "7.1.2"},
type="mock_type",
),
)
assert "serialnum" in str(ex.value)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
{
CONF_HOST: "1.1.1.1",
CONF_USERNAME: "test-username",
CONF_PASSWORD: "test-password",
},
)
assert result["type"] is FlowResultType.ABORT
async def test_zero_conf_malformed_serial(
hass: HomeAssistant,
config_entry: MockConfigEntry,
mock_setup_entry: AsyncMock,
mock_envoy: AsyncMock,
) -> None:
"""Test malformed zeroconf properties."""
await setup_integration(hass, config_entry)
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_USER}
)
assert result["type"] is FlowResultType.FORM
result = await hass.config_entries.flow.async_init(
DOMAIN,
context={"source": SOURCE_ZEROCONF},
data=zeroconf.ZeroconfServiceInfo(
ip_address=ip_address("1.1.1.1"),
ip_addresses=[ip_address("1.1.1.1")],
hostname="mock_hostname",
name="mock_name",
port=None,
properties={"serialnum": "12%4", "protovers": "7.1.2"},
type="mock_type",
),
)
assert result["type"] is FlowResultType.FORM
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
{
CONF_HOST: "1.1.1.1",
CONF_USERNAME: "test-username",
CONF_PASSWORD: "test-password",
},
)
assert result["type"] is FlowResultType.CREATE_ENTRY
assert result["title"] == "Envoy 12%4"
async def test_zero_conf_malformed_fw_property(
hass: HomeAssistant,
config_entry: MockConfigEntry,
mock_setup_entry: AsyncMock,
mock_envoy: AsyncMock,
) -> None:
"""Test malformed zeroconf property."""
await setup_integration(hass, config_entry)
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_USER}
)
assert result["type"] is FlowResultType.FORM
result = await hass.config_entries.flow.async_init(
DOMAIN,
context={"source": SOURCE_ZEROCONF},
data=zeroconf.ZeroconfServiceInfo(
ip_address=ip_address("1.1.1.1"),
ip_addresses=[ip_address("1.1.1.1")],
hostname="mock_hostname",
name="mock_name",
port=None,
properties={"serialnum": "1234", "protvers": "7.1.2"},
type="mock_type",
),
)
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "already_configured"
assert config_entry.data[CONF_HOST] == "1.1.1.1"
assert config_entry.unique_id == "1234"
assert config_entry.title == "Envoy 1234"
async def test_zero_conf_old_blank_entry( async def test_zero_conf_old_blank_entry(
hass: HomeAssistant, hass: HomeAssistant,
mock_setup_entry: AsyncMock, mock_setup_entry: AsyncMock,